Repository navigation
fix(commands): leave self_is_sibling self-loops out of command output - #794
Merged
Merged
Conversation
The self_is_sibling setting adds a note→itself edge so a note shows in its own sibling list in the views. The commands treated it as a real edge: - Create list index listed the note as its own child and repeated its siblings under it (the traversal followed the loop back in). - Export to canvas drew a note→itself edge. - Edge audit reported self-loops on unresolved notes as dangling edges and counted them in mergeable-field comparisons. Skip self-loops (and, for traversals, the subtree under them), as freeze_edges already does. Refs #785
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #785
self_is_siblingadds a note->itself edge for the views. The commands treated it as a real edge:All three now skip self-loops, plus the subtree the traversal followed back through them, as
freeze_edgesalready does. Thread is unaffected (it only looks up the edge it just created).Tests: one new test per command, all on the real WASM graph. Live: on the dev vault's
11-canvas-export/Hub.md, the list index is exactly- Sibling/- Twin.