packageList() extracts github packages, w/ tests

[cebarboza]

• Created packageList() closes extractGithubList inner function #98
  • extractGithubList() closes extractGithubList inner function #98
• Helper requireInstall() closes Write a requireInstall FUN to have a handy method for suggested packages #97

[ariannaa7]

renv::lockfile_validate() returns FALSE when running with mocklock(). Returns TRUE when it is run with a an actual existing renv.lock.

Loading the mocklock() with renv::lockfile_read() works fine, but never gets to that step because of FALSE status. A quick glance of the structure of the mock lock file doesn't reveal anything glaring, but perhaps there is a typo or something else that needs to replicated to be interpreted as an actual lockfile.

[ariannaa7]

Hi @cebarboza,

I attempted to use packageList() and here are my notes:

• requireInstall() effectively prompted me to install jsonvalidate prior to running when I attempted to run packageList
• extractGithubList() returned only the DarwinShinyModules package as expected

The only note is that I had to run packageList() in debug mode because of the issue with the mockLock as mentioned above. Some ideas for the mockLock to ensure that it passes renv::lockfile_validate:

• Checking for small structural differences?
• Creating a physical lockfile for testing and reading that in instead of creating a temporary one
• If we want to continue using mockLock() and it still doesn't pass the validation, then perhaps bypassing the renv::lockfile_validate if reading from mockfile(). I personally would still be concerned that we are missing something and prefer creating an actual renv.lock for testing, but would trust your opinion @cebarboza !

Regarding the tests:
In the renv.lock included in tests/testthat/data, the DarwinShinyModules version is set to 0.3.2.
But the "packageList git repostitories" and "extractGithubListbut" tests expect 0.6.0 so they fail.

[cebarboza]

Hi @ariannaa7 I couldn't replicate running 'mocklock' with packageList(). In the test I am writing a new one from scratch. I will merge and continue with the division and integration with more functions.