feat: support IntersectionObserver v2 trackVisibility/delay options - #144
Open
metonym wants to merge 1 commit into
Open
feat: support IntersectionObserver v2 trackVisibility/delay options#144metonym wants to merge 1 commit into
metonym wants to merge 1 commit into
Conversation
Adds occlusion-aware visibility tracking across the component, multiple- element component, action, and attachment surfaces — needed for trustworthy ad/analytics impression tracking, one of this library's stated use cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trackVisibility/delayoptions across all three surfaces (IntersectionObserver,MultipleIntersectionObserver,intersect/intersectAttachment), enabling occlusion-aware visibility viaentry.isVisible(Intersection Observer v2)trackVisibility/delay/entry.isVisibletype-check cleanlyTest plan
bun test:typespassesbun test:e2epasses (27/27), including a new fixture that verifiesentry.isVisibleisfalsewhile the element is occluded andtrueonce unoccluded (skipped on non-Chromium browsers, since IO v2 is Chromium-only)