WIP [DO NOT MERGE] Add legal notice ("Impressum") - #105
Open
yogan wants to merge 1 commit into
Open
Conversation
ohaz
approved these changes
Mar 24, 2020
ohaz
self-requested a review
March 24, 2020 21:19
ohaz
suggested changes
Mar 24, 2020
ohaz
left a comment
ohaz
left a comment
Contributor
There was a problem hiding this comment.
Actually, on second thought, I don't think it's a good idea to add my legal notice to the repo. It would mean that everyone who clones this repo also has my legal notice on their page. That's kind of wrong. Can we include this after building the docker images somehow?
Contributor
Author
|
That's exactly why I was asking for your approval. As an alternative solution: can you put the HTML file somewhere else and serve it? We could just link to it from the app then. Or is anyone aware that the legal notice has to reside on the same domain? If so, it would get tricky. We could pass the the HTML file to the Docker container via a mount, but I don't have an idea how we can serve it then. Maybe from the BE? |
yogan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the required legal notice ("Impressum") as a static HTML page. Links to it are added in footers of all three views (welcome, patient queue, and admin).
@ohaz: I have taken the content of your legal notice. It's pretty much copypasta. I just reduced it to the bare minimum of markup with very minor cosmetic adjustments (no CSS whatsoever). You should still have a look, after all, it's your personal information that gets shown, so I want your explicit approval.