chore: update dependencies and metashade to v0.6.0 - #97
Merged
Merged
Conversation
The metashade submodule PR #179 moved target packages (hlsl, glsl) under metashade.targets. Updated all imports accordingly: - metashade.hlsl.* -> metashade.targets.hlsl.* - metashade.glsl.* -> metashade.targets.glsl.*
Contributor
There was a problem hiding this comment.
Pull request overview
Updates this sample project to align with Metashade v0.6.0 and refreshes related dependency pins and CI tooling so the generator/compile flow continues to work with the library’s updated module layout.
Changes:
- Bump project version to
0.1.2(Python packaging + vcpkg manifest). - Update Python imports to the
metashade.targets.*namespace to match Metashade v0.6.0. - Refresh pinned Python dependencies and modernize GitHub Actions workflow action versions.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vcpkg.json | Bumps vcpkg manifest version-string to 0.1.2. |
| src/generate.py | Updates Metashade utility imports to metashade.targets.*. |
| src/_impl/vertex_data.py | Updates SM6 vertex shader generator import path. |
| src/_impl/ps.py | Updates SM6 pixel shader + GLSL frag import paths. |
| src/_hlsl.py | Updates DXC/GLSLang utility import paths under metashade.targets.*. |
| src/_glsl.py | Updates GLSLang utility import path under metashade.targets.*. |
| requirements.txt | Updates pinned Python dependency versions (including pytest). |
| pyproject.toml | Bumps project version and raises minimum Metashade/pytest requirements. |
| .github/workflows/python-package.yml | Updates GitHub Actions to newer major versions and bumps release-downloader action. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ppenenko
marked this pull request as ready for review
August 8, 2026 19:17
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (2)
pyproject.toml:15
pytestis listed both as a runtime dependency ([project].dependencies) and as a dev extra ([project.optional-dependencies].dev). Since pytest is only needed to run the test suite, keeping it in runtime dependencies unnecessarily pulls it into normal installs and duplicates version management.
dependencies = [
"metashade>=0.6.0",
"pygltflib==1.16.5",
"pytest>=9.1.1"
]
.github/workflows/python-package.yml:13
- The schedule comment claims this runs at “8:00 AM EDT (12:00 UTC)”, but the cron is always evaluated in UTC year-round. That means it will be 8:00 AM only during EDT (UTC-4) and 7:00 AM during EST (UTC-5). Please clarify the comment (or adjust the cron) so it’s not misleading.
schedule:
# Every Friday at 8:00 AM EDT (12:00 UTC)
- cron: '0 12 * * 5'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #82.
Dependabot Security Fixes
pytest8.4.1→9.1.1Pygments2.19.2→2.20.0marshmallowSchema.load(many=True)3.26.1→3.26.2Metashade Submodule
Updated from
0f90040(v0.5.1+88) to tagv0.6.0(6a9dbb9).Other Dependency Updates
metashade>=0.5.1→metashade>=0.6.0pytestfrom runtimedependencies(kept only underdevoptional dependencies)GitHub Actions Bumps
actions/checkoutactions/setup-pythonrobinraju/release-downloaderCI Updates
glslang-master-windows-Release.zip→glslang-main-windows-x86_64-release.zip(mirrors metashade#204)[3.9, 3.10, 3.11]→[3.11, 3.13, 3.14]— drops 3.9 (dependencies have moved on) and 3.10, adds 3.13 and 3.14requires-python: bumped from>=3.9,<3.12to>=3.11Version Bump
0.1.1→0.1.2inpyproject.tomlandvcpkg.json.Testing
Local test run passed:
1 passed, all 12 shaders compiled and verified successfully.