Removed logging initialization as sideffect - #107
Open
semohr wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
semohr
temporarily deployed
to
integration_tests
August 5, 2026 16:00 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
semohr
temporarily deployed
to
integration_tests
August 5, 2026 16:00 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
semohr
force-pushed
the
logging_refactor
branch
from
August 7, 2026 12:24
2928408 to
093bf17
Compare
semohr
temporarily deployed
to
integration_tests
August 7, 2026 12:25 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
semohr
temporarily deployed
to
integration_tests
August 7, 2026 12:25 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
semohr
force-pushed
the
logging_refactor
branch
from
August 22, 2026 20:24
093bf17 to
96c14d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves logging initialization from module import time to CLI startup, ensuring logging is configured only when the CLI is executed.
This also better reflects the intended separation of responsibilities: libraries should configure their own logging, even if they use our logging utilities. We can always add a notebook magic or similar helper in the future to simplify setup for notebooks and scripting, but that feels out of scope for this change here.