Skip to content

Fix FreeBSD build with FOLLY_USE_JEMALLOC=OFF and header in MallctlHelperTest - #2732

Open
siddiqueirshad wants to merge 1 commit into
meta:mainfrom
siddiqueirshad:fix/freebsd-jemalloc-build
Open

siddiqueirshad wants to merge 1 commit into
meta:mainfrom
siddiqueirshad:fix/freebsd-jemalloc-build

Conversation

@siddiqueirshad

Copy link
Copy Markdown

Summary of changes

On FreeBSD:

  1. When \FOLLY_USE_JEMALLOC\ is \OFF, \ olly/portability/Malloc.h\ did not include <malloc_np.h>, which resulted in missing declarations for \mallocx,
    allocx, \mallctl, and related allocator APIs in downstream translation units. This change includes <malloc_np.h>\ on FreeBSD in the fallback branch of \ olly/portability/Malloc.h\ so allocator symbols remain available.
  2. In \ olly/memory/test/MallctlHelperTest.cpp, FreeBSD supplies non-standard allocator declarations in <malloc_np.h>\ rather than <jemalloc/jemalloc.h>. Conditionally include <malloc_np.h>\ on FreeBSD and safely guard the check on \JEMALLOC_VERSION_MAJOR.

Closes #2720
Closes #2721
Closes #1893

…n MallctlHelperTest

On FreeBSD:
1. When FOLLY_USE_JEMALLOC is OFF, folly/portability/Malloc.h skipped including
   <malloc_np.h>, resulting in missing declarations for mallocx, rallocx, mallctl,
   and related allocator symbols in downstream translation units. Include <malloc_np.h>
   on FreeBSD in the fallback branch so standard non-standard allocator APIs remain available.
2. In MallctlHelperTest.cpp, FreeBSD uses <malloc_np.h> instead of <jemalloc/jemalloc.h>.
   Conditionally include <malloc_np.h> on FreeBSD and safely guard JEMALLOC_VERSION_MAJOR.

Fixes meta#2720
Fixes meta#2721
Fixes meta#1893

Signed-off-by: siddiqui irshad <mohdirshad1306@gmail.com>
@meta-cla

meta-cla Bot commented Oct 28, 2026

Copy link
Copy Markdown

Hi @siddiqueirshad!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant