Repository navigation
Conversation
Prototype: React keeps unhydrated server nodes at the root container, but client-renders a Suspense boundary that has leftover nodes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
slorber
added
pr: bug fix
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: +44 B (0%) Total Size: 12.1 MB 📦 View Changed
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +48 B (0%) Total Size: 12.1 MB 📦 View Changed
ℹ️ View Unchanged
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Alternative fix for the duplicate render of pages opened at non-canonical URLs, like
/tests.html. #12810 explains the root cause and is the fix I recommend: this PR is open for comparison.React doesn't remove extra server nodes left in the root container after hydration (react/react#21021), but it does detect them inside a Suspense boundary, and then client-renders the boundary. Wrapping the app in a root
<Suspense>boundary removes the duplicate whatever empties the first client render. It adds no DOM element, only<!--$-->and<!--/$-->comments to the HTML.Trade-offs compared to #12810:
/tests.htmland/tests/index.html: the client render replaces the server HTML before the route chunk is loaded, so the navbar disappears and reappears.Test Plan
Tested manually on a local website build, served without clean URLs, with a
404.htmlfallback (like Netlify):/tests.html,/tests/index.html,/blog.html,/blog/index.html,/index.htmland/docs/installation.htmlrender once, with a recoverable hydration error 418.Test links
Deploy preview: https://deploy-preview-12811--docusaurus-2.netlify.app/
These URLs render the page twice on
main(compare with the deploy preview of #12805), and once here, but/tests/index.html,/blog/index.htmland/docs/installation/index.htmllog a hydration error:main, but a hydration error)Related issues/PRs
<div id="__docusaurus-app">(breaking change)🤖 Generated with Claude Code