Repository navigation
cli: logs: reconstruct wall-clock timestamps - #622
Merged
Merged
Conversation
BPF log records contain monotonic nanoseconds, but bfcli passes them directly to localtime() as seconds since the Unix epoch. This displays uptime as a time of day. Subtract the event's monotonic age from the current wall-clock time before formatting. Keep the producer's timestamp format unchanged so existing readers remain compatible, and propagate clock errors through the ring-buffer callback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bfcli chain logsinterprets monotonic timestamps as Unix time.Reconstruct each event's wall time from its monotonic age before
formatting it in the local timezone. Propagate clock errors through the
log reader.
Related issue
No linked issue. Log entries currently display time since boot as a
wall-clock timestamp.
Testing
Full test suite passed.
Notes for the reviewer
Producer timestamps remain monotonic nanoseconds for existing readers.
The conversion uses the clock relationship at read time, so clock steps
or suspend can shift buffered timestamps.
AI disclosure
Checklist
make -C $BUILD test_bin testpasses and the code follows the style guidecomponent: subcomponent: short description