Repository navigation
test(gestures): the release cross-check pins the stillness interval - #9939
Conversation
The Core cross-check of the harness's release filter lifted every throw 8 to 16 ms after the last move and every rest 88 ms after it, so a harness stillness interval anywhere from 16 to 87 ms passed all seven cases. Two gestures now lift exactly at Core's stillness interval and 1 ms past it, built from UIKIT_VELOCITY.stillness, and a check confirms that the tracker reads a speed at the first and none at the second. A harness copy with a 39 or 41 ms interval, or a `>=` bound, now fails one case; each passed all seven before.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
|
AI review status for this pull request.
|
PR Analysis Report🔎 Preview ·
|
![astracat-bot[bot]](https://avatars.githubusercontent.com/in/4796231?s=60&v=4){kind=small}
There was a problem hiding this comment.
Approved pending CI: CI has not run on this head yet. This is a draft from a fork, so CI runs once it is marked ready for review and a maintainer adds the ci:run label.
The two boundary lifts, at the stillness interval and 1 ms past it, pin the harness's copy of the release filter to VelocityTracker. A harness interval of 39 or 41 ms, or a >= rest comparison, now fails one case each, where all seven earlier cases passed with them. There is no public API or product behavior change, and there are no blocking findings.
[Automated review]
cixzhang
added
the
ci:run
Maintainer impact
The interaction harness copies Core's release filter, and a Core test compares the two on the same samples. Its cases lifted 8 to 16 ms or 88 ms after the last move, so a harness stillness interval anywhere from 16 to 87 ms passed. This pins the interval, as the automated review suggested on #9725 and #9694.
Evidence
TOUCH_STILLNESS_MSset to 39 or 41 ms, all 7 cases passed.>=bound in the harness's rest check, fail one case each. The unchanged harness passes 10 of 10.Intended invariant
The harness reads a speed for a lift at the stillness interval, and none for a lift 1 ms later, as
VelocityTrackerdoes.Change
UIKIT_VELOCITY.stillnessand 1 ms past it, so they follow Core's constant.Scope
Testing
Local gates at 5f63f9d, on
main62b3e17: Core typecheck,CI=true pnpm lint(no errors, and no warnings in the changed test), Prettier, changeset coverage (nothing ships), the harness's and Core's gesture unit tests (933), and the full unit suites (test:ui19,788 passed;test:node16,430 passed). The mutations under Evidence ran on local, uncommitted copies oftouch.ts; they are not part of this change.