Skip to content

test(DateInput): the wheel contrast proof imports the hermetic Playwright test - #9888

Merged
cixzhang merged 1 commit into
mainfrom
fix/wheelcontrast-hermetic-import
Nov 4, 2026
Merged

cixzhang merged 1 commit into
mainfrom
fix/wheelcontrast-hermetic-import

Conversation

@cixzhang

@cixzhang cixzhang commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Maintainer impact

Main's Lint fails with one ESLint error, so every pull request that merges now reports a red main:

packages/core/src/DateInput/__tests__/WheelContrast.a11y.chromium.spec.ts
  17:1  error  '@playwright/test' import is restricted from being used. Import from
               '@astryxdesign/a11y-spec/playwright' instead: its `test` keeps every
               browser context off remote hosts  no-restricted-imports

Cause

Two pull requests merged minutes apart, and each passed its own checks:

Change

The spec imports expect, test, Browser and Page from @astryxdesign/a11y-spec/playwright, which re-exports Playwright and gives test the hermetic browser. The spec serves Storybook locally, so it makes no remote request that the hermetic browser would refuse. Test only: no product code and no Changeset.

Scope

  • No intended public API, product behavior, visual direction, or policy change.
  • Public text and artifacts contain no internal Meta context.

Testing

  • pnpm exec eslint on the spec: 0 errors. One warning remains, and it was there before this change.
  • Core tsc --noEmit: no error in the spec.
  • CI Lint and the release check's contract shard on main after the merge.

Posted by Cindy's agent on her behalf.

…ight test

#9853 added the spec with @playwright/test; #9811 made that import an
ESLint error. Each was green alone; together main Lint fails.
@cixzhang cixzhang added the ci:run A maintainer lets this outside contributor's pull request run CI (AST-030 FR17) label Nov 4, 2026
@vercel

vercel Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 4, 2026 6:22am UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 4, 2026
@astracat-bot

astracat-bot Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

AI review status for this pull request.

Review status Updated
🟢 Reviewed (for maintainers only) Nov 4, 2026, 6:30 AM UTC

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

PR Analysis Report

🔎 Preview · 5119301

Storybook · Sandbox · built from this PR's head

Modified components

Component Size LoC Visual · A11y · RTL
DateInput · Storybook 147.0 kB (0) · 15.5 kB CSS (0) 5,034 (0) ✓ · ✓ · ✓

Package size: measured; main has no measurement of the merge base to compare yet.

API changes: cli +8 · ~0 · −0 (against the merge base's committed report); theme-butter +1 · ~0 · −0 (against the merge base's committed report); theme-chocolate +1 · ~0 · −0 (against the merge base's committed report); theme-gothic +1 · ~0 · −0 (against the merge base's committed report); theme-matcha +1 · ~0 · −0 (against the merge base's committed report); theme-neutral +1 · ~0 · −0 (against the merge base's committed report); theme-stone +1 · ~0 · −0 (against the merge base's committed report); theme-y2k +1 · ~0 · −0 (against the merge base's committed report)

Committed API report behind this build: cli 8 rows, theme-butter 1 row, theme-chocolate 1 row, theme-gothic 1 row, theme-matcha 1 row, theme-neutral 1 row, theme-stone 1 row, theme-y2k 1 row; run pnpm api:report.

15 API changes (advisory)
Package Where Signature Usage
+ cli ./api · Types · type SearchResultEntry deprecated?: ComponentDeprecation | undefined import type {SearchResultEntry} from '@astryxdesign/cli/api'; const x: SearchResultEntry = {deprecated: …}
+ cli ./authoring · Types · interface ComponentDeprecation interface ComponentDeprecation import type {ComponentDeprecation} from '@astryxdesign/cli/authoring'
+ cli ./authoring · Types · interface MultiComponentDoc deprecated?: ComponentDeprecation import type {MultiComponentDoc} from '@astryxdesign/cli/authoring'; const x: MultiComponentDoc = {deprecated: …}
+ cli ./authoring · Types · interface SingleComponentDoc deprecated?: ComponentDeprecation import type {SingleComponentDoc} from '@astryxdesign/cli/authoring'; const x: SingleComponentDoc = {deprecated: …}
+ cli ./doc · Types · interface ComponentBaseDoc deprecated?: ComponentDeprecation import type {ComponentBaseDoc} from '@astryxdesign/cli/doc'; const x: ComponentBaseDoc = {deprecated: …}
+ cli ./doc · Types · interface SubComponentDoc deprecated?: ComponentDeprecation import type {SubComponentDoc} from '@astryxdesign/cli/doc'; const x: SubComponentDoc = {deprecated: …}
+ cli ./doc · Also exported from an earlier entry point · ComponentDeprecation ComponentDeprecation (./authoring) import {ComponentDeprecation} from '@astryxdesign/cli/doc'
+ cli ./template · Also exported from an earlier entry point · ComponentDeprecation ComponentDeprecation (./authoring) import {ComponentDeprecation} from '@astryxdesign/cli/template'
+ theme-butter Stylesheets · var --duration-exit (./theme.css) var --duration-exit (./theme.css) .my-scope { --duration-exit: …; }
+ theme-chocolate Stylesheets · var --duration-exit (./theme.css) var --duration-exit (./theme.css) .my-scope { --duration-exit: …; }
+ theme-gothic Stylesheets · var --duration-exit (./theme.css) var --duration-exit (./theme.css) .my-scope { --duration-exit: …; }
+ theme-matcha Stylesheets · var --duration-exit (./theme.css) var --duration-exit (./theme.css) .my-scope { --duration-exit: …; }
+ theme-neutral Stylesheets · var --duration-exit (./theme.css) var --duration-exit (./theme.css) .my-scope { --duration-exit: …; }
+ theme-stone Stylesheets · var --duration-exit (./theme.css) var --duration-exit (./theme.css) .my-scope { --duration-exit: …; }
+ theme-y2k Stylesheets · var --duration-exit (./theme.css) var --duration-exit (./theme.css) .my-scope { --duration-exit: …; }

Touched components checked; add ci:run-visual, ci:run-a11y or ci:run-rtl to run the full suites.

Current run: CI concluded failure; parts of this report may be missing.


Generated by PR Enrichment workflow | View full report

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending CI: moving this spec's import to @astryxdesign/a11y-spec/playwright clears the only lint error on main and changes nothing that ships.

  • The required test check failed on this head because a CI runner shut down before the test jobs were admitted, not because of this change; re-run the failed jobs so CI completes before merge.

ESLint now reports no error on the spec, and its seven contrast tests still pass in Chromium with the hermetic base test.

[Automated review]

@cixzhang
cixzhang merged commit bd69bed into main Nov 4, 2026
101 of 104 checks passed
@github-actions
github-actions Bot deleted the fix/wheelcontrast-hermetic-import branch November 5, 2026 06:03

This branch was successfully deployed

1 active deployment
Preview — 51193017 Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:run A maintainer lets this outside contributor's pull request run CI (AST-030 FR17) CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants