Repository navigation
test(DateInput): the wheel contrast proof imports the hermetic Playwright test - #9888
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
PR Analysis Report🔎 Preview ·
|
| Component | Size | LoC | Visual · A11y · RTL |
|---|---|---|---|
| DateInput · Storybook | 147.0 kB (0) · 15.5 kB CSS (0) | 5,034 (0) | ✓ · ✓ · ✓ |
Package size: measured; main has no measurement of the merge base to compare yet.
API changes: cli +8 · ~0 · −0 (against the merge base's committed report); theme-butter +1 · ~0 · −0 (against the merge base's committed report); theme-chocolate +1 · ~0 · −0 (against the merge base's committed report); theme-gothic +1 · ~0 · −0 (against the merge base's committed report); theme-matcha +1 · ~0 · −0 (against the merge base's committed report); theme-neutral +1 · ~0 · −0 (against the merge base's committed report); theme-stone +1 · ~0 · −0 (against the merge base's committed report); theme-y2k +1 · ~0 · −0 (against the merge base's committed report)
Committed API report behind this build: cli 8 rows, theme-butter 1 row, theme-chocolate 1 row, theme-gothic 1 row, theme-matcha 1 row, theme-neutral 1 row, theme-stone 1 row, theme-y2k 1 row; run pnpm api:report.
15 API changes (advisory)
| Package | Where | Signature | Usage | |
|---|---|---|---|---|
| + | cli |
./api · Types · type SearchResultEntry |
deprecated?: ComponentDeprecation | undefined |
import type {SearchResultEntry} from '@astryxdesign/cli/api'; const x: SearchResultEntry = {deprecated: …} |
| + | cli |
./authoring · Types · interface ComponentDeprecation |
interface ComponentDeprecation |
import type {ComponentDeprecation} from '@astryxdesign/cli/authoring' |
| + | cli |
./authoring · Types · interface MultiComponentDoc |
deprecated?: ComponentDeprecation |
import type {MultiComponentDoc} from '@astryxdesign/cli/authoring'; const x: MultiComponentDoc = {deprecated: …} |
| + | cli |
./authoring · Types · interface SingleComponentDoc |
deprecated?: ComponentDeprecation |
import type {SingleComponentDoc} from '@astryxdesign/cli/authoring'; const x: SingleComponentDoc = {deprecated: …} |
| + | cli |
./doc · Types · interface ComponentBaseDoc |
deprecated?: ComponentDeprecation |
import type {ComponentBaseDoc} from '@astryxdesign/cli/doc'; const x: ComponentBaseDoc = {deprecated: …} |
| + | cli |
./doc · Types · interface SubComponentDoc |
deprecated?: ComponentDeprecation |
import type {SubComponentDoc} from '@astryxdesign/cli/doc'; const x: SubComponentDoc = {deprecated: …} |
| + | cli |
./doc · Also exported from an earlier entry point · ComponentDeprecation |
ComponentDeprecation (./authoring) |
import {ComponentDeprecation} from '@astryxdesign/cli/doc' |
| + | cli |
./template · Also exported from an earlier entry point · ComponentDeprecation |
ComponentDeprecation (./authoring) |
import {ComponentDeprecation} from '@astryxdesign/cli/template' |
| + | theme-butter |
Stylesheets · var --duration-exit (./theme.css) |
var --duration-exit (./theme.css) |
.my-scope { --duration-exit: …; } |
| + | theme-chocolate |
Stylesheets · var --duration-exit (./theme.css) |
var --duration-exit (./theme.css) |
.my-scope { --duration-exit: …; } |
| + | theme-gothic |
Stylesheets · var --duration-exit (./theme.css) |
var --duration-exit (./theme.css) |
.my-scope { --duration-exit: …; } |
| + | theme-matcha |
Stylesheets · var --duration-exit (./theme.css) |
var --duration-exit (./theme.css) |
.my-scope { --duration-exit: …; } |
| + | theme-neutral |
Stylesheets · var --duration-exit (./theme.css) |
var --duration-exit (./theme.css) |
.my-scope { --duration-exit: …; } |
| + | theme-stone |
Stylesheets · var --duration-exit (./theme.css) |
var --duration-exit (./theme.css) |
.my-scope { --duration-exit: …; } |
| + | theme-y2k |
Stylesheets · var --duration-exit (./theme.css) |
var --duration-exit (./theme.css) |
.my-scope { --duration-exit: …; } |
Touched components checked; add ci:run-visual, ci:run-a11y or ci:run-rtl to run the full suites.
Current run: CI concluded failure; parts of this report may be missing.
Generated by PR Enrichment workflow | View full report
There was a problem hiding this comment.
Approved pending CI: moving this spec's import to @astryxdesign/a11y-spec/playwright clears the only lint error on main and changes nothing that ships.
- The required
testcheck failed on this head because a CI runner shut down before the test jobs were admitted, not because of this change; re-run the failed jobs so CI completes before merge.
ESLint now reports no error on the spec, and its seven contrast tests still pass in Chromium with the hermetic base test.
[Automated review]
Maintainer impact
Main's
Lintfails with one ESLint error, so every pull request that merges now reports a red main:Cause
Two pull requests merged minutes apart, and each passed its own checks:
WheelContrast.a11y.chromium.spec.ts, importing from@playwright/test.@astryxdesign/a11y-spec/playwright. Its checks ran before the new spec was on main.Change
The spec imports
expect,test,BrowserandPagefrom@astryxdesign/a11y-spec/playwright, which re-exports Playwright and givestestthe hermetic browser. The spec serves Storybook locally, so it makes no remote request that the hermetic browser would refuse. Test only: no product code and no Changeset.Scope
Testing
pnpm exec eslinton the spec: 0 errors. One warning remains, and it was there before this change.tsc --noEmit: no error in the spec.Lintand the release check's contract shard on main after the merge.Posted by Cindy's agent on her behalf.