Repository navigation
Conversation
This reverts commit 1f47db9.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
AI review status for this pull request.
|
github-actions
Bot
requested review from
cvkxx,
ernestt,
kentonquatman and
rubyycheung
November 3, 2026 02:41
Contributor
Author
|
/approve-spec aa56a59 |
Contributor
Author
|
/revoke-spec aa56a59 |
Contributor
PR Analysis Report
Generated by PR Enrichment workflow | View current CI run |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User impact
After #9636, a person who presses a Switch, slides off it and releases elsewhere still turns the switch on. The press cannot be taken back, so a misplaced press changes a setting.
Problem and solution fit
The Switch changes state on the way down. The accessibility contract
switch.state.survives-an-aborted-pressfails onmainfor the off, described, label-hidden, required and invalid states. Reverting #9636 restores the previous Switch behavior, which passes that contract.Expected behavior and authority
WCAG 2.2 SC 2.5.2 Pointer Cancellation, as enforced by the required real-browser layer of the Switch accessibility contract (
Switch.a11y.chromium.spec.ts).Smallest restoration
A plain
git revertof the #9636 squash commit (1f47db9). No other change.Evidence
mainatSwitch.a11y.chromium.spec.ts:185.Scope
Testing
The accessibility spec-test contracts job, run on this pull request.