Skip to content

Revert "feat(Switch): the touch presentation, for every pointer (#9636)" - #9682

Closed
cixzhang wants to merge 1 commit into
mainfrom
revert-9636-switch-aborted-press
Closed

cixzhang wants to merge 1 commit into
mainfrom
revert-9636-switch-aborted-press

Conversation

@cixzhang

@cixzhang cixzhang commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

User impact

After #9636, a person who presses a Switch, slides off it and releases elsewhere still turns the switch on. The press cannot be taken back, so a misplaced press changes a setting.

Problem and solution fit

The Switch changes state on the way down. The accessibility contract switch.state.survives-an-aborted-press fails on main for the off, described, label-hidden, required and invalid states. Reverting #9636 restores the previous Switch behavior, which passes that contract.

Expected behavior and authority

WCAG 2.2 SC 2.5.2 Pointer Cancellation, as enforced by the required real-browser layer of the Switch accessibility contract (Switch.a11y.chromium.spec.ts).

Smallest restoration

A plain git revert of the #9636 squash commit (1f47db9). No other change.

Evidence

  • Reproduction before the change: the accessibility spec-test contracts job fails on main at Switch.a11y.chromium.spec.ts:185.
  • Result after the change: the same job passes on this branch.
  • Representative unchanged path: other components' contracts are untouched.
  • Regression test or other mutation-sensitive proof: the existing Switch accessibility contract.

Scope

  • One defect is restored.
  • Separable contradictory or unsettled tagalongs were removed or split.
  • No new public API, visual representation, default, or interaction model is hidden under the bug-fix label.
  • Public text and artifacts contain no internal Meta context.

Testing

The accessibility spec-test contracts job, run on this pull request.

@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 3, 2026 2:51am UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 3, 2026
@astracat-bot

astracat-bot Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

AI review status for this pull request.

Review status Updated
🔄 In progress (for maintainers only) Nov 3, 2026, 2:41 AM UTC

@github-actions github-actions Bot added the needs:design-review Affects visuals — Design should review label Nov 3, 2026
@cixzhang

cixzhang commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

/approve-spec aa56a59

@cixzhang

cixzhang commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

/revoke-spec aa56a59

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

PR Analysis Report

Current run: The current CI run concluded skipped. Current analysis is unavailable.


Generated by PR Enrichment workflow | View current CI run

@github-actions github-actions Bot added the needs:spec-owner-review Current knowledge records await owner approval label Nov 3, 2026
@cixzhang cixzhang closed this Nov 3, 2026
@github-actions
github-actions Bot deleted the revert-9636-switch-aborted-press branch November 3, 2026 06:05

This branch was successfully deployed

1 active deployment
Preview — aa56a596 Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. needs:design-review Affects visuals — Design should review needs:spec-owner-review Current knowledge records await owner approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant