Repository navigation
ci: the WebKit interaction lane also runs for #8360's new click-guard paths - #9376
Conversation
… paths Co-authored-by: vjeux <197597+vjeux@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
|
AI review status for this pull request.
|
PR Analysis Report🔎 Preview ·
|
| Before | After | Change | |
|---|---|---|---|
| Job-minutes per PR update | 78.7 | 81.3 | +2.7 |
| Runner pool, runner-minutes a day | 36,690 | 37,932 | +1,241 (+3.4%) |
| Average concurrent jobs | 25.5 | 26.3 | +0.9 |
| Time to green (median → this run) | — | 11.9 min | — |
| Runs a day | 466 | 466 | 0 |
Changed jobs: pr-interaction-webkit changed: standard
Not measured (the jobs that use these keep their recent minutes above): .github/scripts/ci-interaction-webkit.test.mjs.
Assumptions: before is each job's average over the last 20 pull-request runs; after keeps that for unchanged jobs and uses this run's minutes for added or changed ones, weighted by how often each changed job ran in those runs; runs a day averages the seven whole days before today; time to green compares this run with the median of those runs that ran the same jobs.
Generated by PR Enrichment workflow | View full report
![astracat-bot[bot]](https://avatars.githubusercontent.com/in/4796231?s=60&v=4){kind=small}
There was a problem hiding this comment.
This looks ready to merge. The WebKit lane's scope adds seven paths and drops none, so no pull request loses the proof, and the routing tests pass. One optional follow-up: no test pins the new paths, because the #8360 replay still passes on GestureHost.ts alone. Adding them to the "runs for" list in ci-interaction-webkit.test.mjs would catch a later edit that drops one.
[Automated review]
| 'packages/core/src/Toast/Toast.tsx', | ||
| 'packages/core/src/Selector/useSelectorPresentation.ts', | ||
| 'packages/core/src/utils/clickGuard.ts', | ||
| 'packages/core/src/utils/focusReturn.ts', |
There was a problem hiding this comment.
Optional: the seven paths this PR adds to the scope aren't asserted anywhere. This file passes unchanged against the old regex, because the #8360 replay below already runs on GestureHost.ts. Adding packages/core/src/utils/clickGuard.ts, inputStream.ts, coarsePointer.ts, flatTree.ts, selectionLock.ts, packages/core/src/privateAttributes/hapticSwitch.stylex.ts and packages/core/src/hooks/isRtlElement.ts to the "runs for" list above would pin them.
…files (#9377) * ci: the WebKit interaction lane also runs for the pager and Carousel paging files Co-authored-by: vjeux <197597+vjeux@users.noreply.github.com> * Merge main (#9376) into the pager WebKit scope branch * Merge remote-tracking branch 'origin/main' into ci/webkit-scope-pager * ci: the WebKit lane runs the pager's proof; Carousel paging stays with the Chromium proofs The pager spec bundles its own page with esbuild, so it runs in WebKit like the gesture and motion specs. Carousel paging's spec renders its Storybook story, which this lane leaves to the Chromium proofs, so its files no longer start a WebKit run that would test nothing of theirs. Co-authored-by: vjeux <197597+vjeux@users.noreply.github.com> * ci: the WebKit scope covers the two shared files the pager's page bundles usePager reads sharedResizeObserver and useIsomorphicLayoutEffect, so an edit to either changes what the pager's WebKit proof runs. A bundle-reach case for the pager's page runs once that page exists. Co-authored-by: vjeux <197597+vjeux@users.noreply.github.com>
Maintainer impact
pr-interaction-webkit) runs when a pull request touches the press, touch and gesture code it guards. fix(core): one click guard for the menu press model and the gesture host #8360 adds new shared interaction modules: the click guard, the coarse-pointer and input-stream helpers, the flat tree, the selection lock, and the haptic switch style. With the old scope, an edit to any of them would skip the WebKit proof.hooks/isRtlElement(the direction read the gesture code uses)..githubchanges can't run with the repository's workflows. The code change stays in fix(core): one click guard for the menu press model and the gesture host #8360.Change
.github/workflows/ci.yml,pr-interaction-webkitscopepaths:utils/(…|flatTree|inputStream|clickGuard|selectionLock|coarsePointer),privateAttributes/hapticSwitch.stylex.ts,hooks/(…|isRtlElement)..github/scripts/ci-interaction-webkit.test.mjs: the "untouched" exampleutils/clickGuard.ts, now in scope, becomesutils/focusReturn.ts.Evidence
main, the new prefixes match onlypackages/core/src/hooks/isRtlElement.ts, which already exists. The other eleven matching files are all added by fix(core): one click guard for the menu press model and the gesture host #8360, so they route nothing until it lands.ci-interaction-webkit,ci-interaction,workflow-pathsandci-tooling-routingtests pass (59 tests). The existing fix(core): one click guard for the menu press model and the gesture host #8360 routing case (utils/clickGuard.tsruns the lane) already covers the new scope.hooks/isRtlElement.ts, which has changed rarely (last in fix(core): auto-detect RTL for arrow-key navigation in focus hooks #4350). Expected runner-pool change is near zero today; it grows only with pull requests that touch fix(core): one click guard for the menu press model and the gesture host #8360's modules once it lands. No effect on time to green for other pull requests.Scope