Repository navigation
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #8175 and #8665 (with #8666's pen driver). Carries #8562 (Core's internal entries) as a dependency; if the entries land differently, this follows her decision. Review only this PR's change: vjeux/astryx@01e856a...2758073; later heads only merge #8175, #8665 and #8666.
Why
With a mouse or a stylus, nothing pulls to refresh: the pull reads only a finger, so a drag at the top of a refreshable list does nothing.
What led to it
Part of the touch-presentations program (
spec:AST-094). Its FR43, now onmain, has gestures run for every pointer, keeping off only what it lists; the pull to refresh isn't on that list.Options and tradeoffs
overscroll-behavior: nonewould remove the page's own rubber band, with no pull to replace it for a wheel.Why this choice
The third follows FR43 with the least new behavior: every pointer shares one mapping, trigger, settle and drawing. Under a fine pointer the browser keeps its own overscroll at the page's top, and the control watches no scroll (FR24). A pen's or a mouse's pull clears the text selection its drag started, then holds selection off, as a finger's does. Under Reduce Motion a release cross-fades where a finger let go or the primary pointer is coarse (
design:reduced-motionDR2) and lands at once elsewhere (DR3). A trackpad's or a wheel's scroll follows in #8697.How to check it
In a desktop browser, on the RefreshControl story "On the page":
Evidence
touch-support-bundlefails because this branch carries fix(useScrollLock): keep the page where it is while an overlay is open #8098's scroll lock; test(core): a touch component's import carries its gesture code, and nothing else does #8671's per-component test replaces it and passes here.