chore(core): the press controller leaves an action group's tracked actions to its tracker by vjeux · Pull Request #8637 · meta/astryx

vjeux · 2026-10-27T01:49:59Z

Review this PR alone: vjeux/astryx@uikit/f2-click-guard...uikit/c01-press-group-skip

Maintainer impact

Part of the UIKit-parity work: in a group of sibling actions (an alert's buttons, a button group, a toggle group) you can press one and slide to another, as on iOS (family:action-groups, from #8622). The group's own tracker paints the press on the action under the pointer. The page-wide press controller paints the same buttons, so the two erase each other: the controller's release fade wipes the group's highlight, and the button you started on stays lit beside the one you slid to.

Intended invariant

One painter per press. The controller already calls itself the one writer of the press attribute; a group takes that role only for the actions it tracks.

Change

What led to it: building the group tracking for AlertDialog and ButtonGroup showed the double paint.

Skip every element inside a tracking group: rejected, it would also silence members the group doesn't track, such as a field or a split button's menu trigger.
Chosen: the group marks each action it tracks (data-astryx-press-group-item), and the controller paints nothing on a marked action. The mark is there before the first press, and the group can use the same attribute to find its actions.

The controller still records the touch on a marked action, so a scroll it starts still brakes the next touch. Where the primary pointer is coarse the controller also paints a mouse press itself (#8046); on a marked action it leaves that to the group too, while a Space press, which the group doesn't track, still paints. No component renders the marker yet: nothing changes until each group adopts it (#8083, #8657, #8660).

Evidence

packages/core/src/utils/pressFeedback.test.ts, six new cases (below).

Scope

No intended public API, product behavior, visual direction, or policy change. utils/pressFeedback.ts is internal: it is not on a published entry point.
Product changes discovered during the work were removed or split.
Public text and artifacts contain no internal Meta context.

Testing

Nothing to check by hand yet: no component carries the marker.

What was run: six new unit tests. The controller paints nothing on a marked action and leaves the group's paint alone, for a finger and for a mouse on a touch-first device; those fail without this change. It still paints an unmarked member, which fails if the skip checks group membership instead of the mark, and a Space press on a marked action. It still records the touch for the scroll brake, which fails if the skip comes first. Typecheck, lint, the core unit suite and the press accessibility tests pass locally; GitHub Actions isn't running on this repository right now.

Stack: on #8360, which carries #8076. The adoptions (#8083, #8657, #8660) stack on this pull request.

startCompositorTrace keeps every Display::FrameDisplayed in the browser, and those events carry no page identity: with a second page animating, a stall inside the block passed busyWindowProof with presented, crediting the other page's frames. It now throws when another page is open as it starts or stops, and says the record is browser-wide (JSDoc and README). Negative control: another animating page makes it refuse to start, and a page opened mid-trace makes stop() refuse.

… instruments

A bare relative ASTRYX_WEBKIT_SHADER_CACHE was mounted as a named volume instead of a host directory, and an empty one made mkdirSync throw. The script now resolves a set value with path.resolve and falls back to the default cache directory on an empty one.

… path) into the recorder stand-down # Conflicts: # internal/interaction-harness/src/harness.interaction.browser.spec.ts

…ce; await it before the counted window The README, waitForRest's JSDoc and traceRendering's JSDoc said a traced waitForRest reads no style. Its one read of the element's animations, as it is called, restyles the element when an animation is already running there (2 Layouts and 2 style recalculations in the anchored fixture, 200 ms into its animation). They now say so and tell a proof to await it right after the action that starts the motion, before the window it counts.

…ch-action rules in @layer reset, the watcher split into meta#8589) into meta#8293

Under Reduce Motion, detaching mid-dip landed the waiting move in the model at the end of the task, but with no element attached the landing wrote nothing, so a call that owns its opacity left its dip's low opacity inline on that node: attaching the same node again in a later task (a Suspense or Activity reveal) showed it at opacity 0. The unmount's landing now writes to the node just detached, as dispose() does to its element. The test fails on the previous head. (Found on meta#8067; fixed here because meta#8056, which carries the planner, is approved at its exact head.)

…element support

… against its span In WebKit the rAF negative control could read "1/1 moved": one frame from before the block arrived 45 ms into it, and the moved criterion divided by the delivered frames. A part that delivered fewer than minJudgedFrames frames is now judged against its span, as one that delivered none was (busy.test.ts case; it fails on the previous rule). The README and the self-test header now say only the busy-main-thread proof carries a negative control beside its positive check.

…into n8548 # Conflicts: # internal/interaction-harness/README.md

…into n8549

…into n8446b

The lock moved to utils/selectionLock.ts with the shared input stream, and stacks based below that move import it from gestures/selectionLock.ts; a tree carrying both failed to typecheck. The case imports the old path and expects the utils module's functions. Fails on this head.

…rom utils A one-line transition re-export at gestures/selectionLock.ts keeps `import {lockSelection} from '../gestures/selectionLock'` working for the stacks based below the move to utils, so a tree that carries both typechecks. Remove it once they have moved up.

…meta#8320 bf6a6a0) into meta#8358

…#8360

…line) as a dependency

A watcher already adds nothing to the derived touch-action, and manageStyle is per element, so attaching one with manageStyle: false beside a claiming recognizer switched off that recognizer's touch-action (spec:AST-094 FR18). The README now says a watcher adds nothing instead. Co-authored-by: Christopher Chedeau <vjeuxx@gmail.com>

… line

…a fixes

…l, straight or diagonal, and not before spec:AST-094 FR20's verification names a finger moved 9 px and 10 px straight, and (7, 7) and (8, 8) diagonally: a scroll above the touch takes it only once the finger has travelled 10 px from where it landed. The host already measures that distance; these cases pin the boundary.

…EADME) into meta#8293

…g running Landing a waiting Reduce Motion move on the node just detached rebuilt every channel the landing touched there, so an axis still moving (a coast on y while x waited in a dip) was baked onto the detached node again and promoted it, leaving an animation, timers and will-change behind. After the landing, the unmount now cancels what runs, clears the retire timers and demotes, before the target goes back to none. The test fails on the previous head.

…'s tracked actions to its tracker) onto F2's line (meta#8360 777ff9a) Conflicts, doc text only, in utils/pressFeedback.ts and its test: the header keeps the line's selection-lock and touchcancel paragraphs, then the group-item paragraph, and lists the group-item exports; the test imports both sides' names.

…77ff9a) into the AlertDialog tracking base

… tip meta#8360) into meta#8083

The document press controller painted AlertDialog's actions on its own clock beside the group's tracker, so AlertDialog took them off the controller by overriding Button's pressable marker, which also took them off the scroll brake. Each tracked action now renders the shared group item marker (`pressGroupItemProps`, meta#8637) from its first render: the controller leaves a pointer's press there to the tracker, the one painter, and still records the touch. The marker is also the tracker's item selector, so the actions are named once. The inline preview is not tracked and keeps the controller's press. The selection lock is imported from utils/selectionLock, its home since meta#8356; the gestures path is a transition re-export. The unit case checks both markers on the open alert (fails on the previous head: no group item marker) and neither group marker in the inline preview.

…01's meta#8637 helper) into meta#8084 # Conflicts: # packages/core/src/AlertDialog/AlertDialog.test.tsx # packages/core/src/AlertDialog/AlertDialog.tsx

…01's meta#8637 helper) into meta#8095 # Conflicts: # packages/core/src/AlertDialog/AlertDialog.tsx

…'s tracked actions to its tracker) onto F2's line (meta#8360 df700c4) Conflicts, doc text only, in utils/pressFeedback.ts and its test: the header keeps the line's selection-lock and touchcancel paragraphs, then the group-item paragraph, and lists the group-item exports; the test imports both sides' names.

df700c4) into the AlertDialog tracking base

…60f08c) into meta#8083

…'s tracked actions to its tracker) onto F2's fZ (meta#8360 23ade34) Conflicts, doc text only, in utils/pressFeedback.ts and its test: the header keeps the line's selection-lock and touchcancel paragraphs, then the group-item paragraph, and lists the group-item exports; the test imports both sides' names.

…a#8360 23ade34) into the AlertDialog tracking base

…, C01's meta#8637 helper e8bb92b) into meta#8083

…tracking base

…d750) into meta#8083

… into meta#8084

astracat-bot

Changes requested: the press-group marker this pull request adds is already on main, so the branch needs a rebase that will most likely leave nothing to land.

main already owns the marker in privateAttributes/pressGroupItem.stylex.ts (from #8083 and #9771), and this branch's copy in utils/pressFeedback.ts conflicts with main in all three of its own files.
The mouse skip in buttonSurfaceAt (pressFeedback.ts:480-482, pinned by pressFeedback.test.ts:600-608) leaves a mouse press on a marked action unpainted where the primary pointer is coarse, against family:action-groups FR1 and FR5, which keep the group's tracker to a finger and a pen.
The diff carries 26,918 authored lines, 26,783 of them the #8360/#8076 stack, with no size exemption, and that stack has since landed on main.
The carried stack contradicts current spec in places main has already fixed: GestureHost attaches only under a coarse primary pointer (AST-094 FR19/FR43, react-component-runtime INV13), PressTracker is a class (INV13), a DropdownMenu trigger keeps 10 px of drift on a fine primary pointer (useMenuPress FR9), and useFingerScroll copies useAttachment instead of calling it.

Rebase onto main, keep only what main lacks, and close the pull request if nothing remains.

[Automated review]

astracat-bot · 2026-11-03T23:22:30Z

@@ -344,6 +475,11 @@ function buttonSurfaceAt(
  if (pointerId == null && element !== target) {
    return null;
  }
+  // A group's tracker paints a pointer's press on its actions, a mouse's too;
+  // a key's press is the action's own.
+  if (pointerId != null && trackedByGroup(element)) {


On a phone or tablet this leaves a mouse press on a marked action unpainted: :active is dropped there, and under family:action-groups FR1 and FR5 no group tracker follows a mouse. main has the mark name the pointers its tracker follows (pressGroupItemProps(['touch', 'pen'])) and skips only those.

astracat-bot · 2026-11-03T23:22:30Z

+ * it, and the controller paints none there. The owner renders it on each
+ * action its tracker follows, so it is in place before the first press.
+ */
+export const PRESS_GROUP_ITEM_ATTRIBUTE = 'data-astryx-press-group-item';


main already owns this attribute in privateAttributes/pressGroupItem.stylex.ts (from #8083 and #9771), and this file conflicts with main. A rebase should drop this copy and use that module.

vjeux · 2026-11-03T23:28:18Z

Closing: main already has this change (the group-item marker via #8083, and the card-45 mouse rule via #9771).

…ions to its tracker meta#8637's own change. A press on an action a group tracks (the group item marker) is the group's tracker's to paint, for a finger and, on a touch-first device, for a mouse too; the controller paints nothing there. Absorbs meta#8637 (ed3d750).

… the meta#8637 helper on fZ)

…a#8360) into the ButtonGroup review base

…ertDialog hold

cixzhang and others added 30 commits October 26, 2026 14:00

Merge meta#8548 (the compositor record refuses another page) into the…

7613c98

… instruments

Merge facebook#8549 (compositor record refuses another page, shader c…

a1e7176

… path) into the recorder stand-down # Conflicts: # internal/interaction-harness/src/harness.interaction.browser.spec.ts

Merge meta#8320 (cixzhang's bf6a6a0: own scroll never a finger's, tou…

95bead4

…ch-action rules in @layer reset, the watcher split into meta#8589) into meta#8293

Merge meta#8521 (a node detached mid-dip lands its move) into pseudo-…

c27baac

…element support

Merge meta#8293 (cixzhang's meta#8320 bf6a6a0) into meta#8356

0985ac7

Merge n8045 (the busy verdict judges a thin window against its span) …

f1c5125

…into n8548 # Conflicts: # internal/interaction-harness/README.md

Merge n8548 (the busy verdict judges a thin window against its span) …

bd50829

…into n8549

Merge n8549 (the busy verdict judges a thin window against its span) …

f405e7f

…into n8446b

Merge meta#8356 (the selection lock's transition re-export; cixzhang's …

c91f97e

…meta#8320 bf6a6a0) into meta#8358

Merge meta#8358 (the selection lock's transition re-export) into meta…

6225083

…#8360

Merge f405e7f (meta#8446: CodeBunny's meta#8045 round up the harness …

959f1e1

…line) as a dependency

Merge meta#8309 (959f1e1: meta#8446 f405e7f) into the gesture hook fixes

4e19448

Merge meta#8315 (4e19448: meta#8309 959f1e1) into the host line

7455721

Merge meta#8315 (4e19448: meta#8309 959f1e1) into the gesture watcher

d0d7f6a

Merge meta#8589 (a watcher needs no manageStyle: false) into the host…

029e4fd

… line

Merge meta#8336 (meta#8315 4e19448, meta#8589's README) into the aren…

cd49a87

…a fixes

Merge meta#8320 (cixzhang's cd49a87: meta#8446 f405e7f, meta#8589's R…

32d2acc

…EADME) into meta#8293

Merge facebook#8293 (cixzhang's facebook#8320 cd49a87) into facebook#…

af0a0e0

Merge meta#8356 (cixzhang's meta#8320 cd49a87) into meta#8358

3ee997f

Merge meta#8358 (cixzhang's meta#8320 cd49a87) into meta#8360

559ab88

vjeux added a commit to vjeux/astryx that referenced this pull request Nov 3, 2026

Merge uikit/c01-8637-on-f2 (e7b0a3e: meta#8637 on F2's tip meta#8360 7…

d61d5eb

…77ff9a) into the AlertDialog tracking base

vjeux added a commit to vjeux/astryx that referenced this pull request Nov 3, 2026

Merge the AlertDialog tracking base (3671d33: C01's meta#8637 on F2's…

ef25c4b

… tip meta#8360) into meta#8083

vjeux added a commit to vjeux/astryx that referenced this pull request Nov 3, 2026

Merge meta#8084 (59d2fda: the press-group item marker, F2's tip via C…

be67c30

…01's meta#8637 helper) into meta#8095 # Conflicts: # packages/core/src/AlertDialog/AlertDialog.tsx

vjeux added a commit to vjeux/astryx that referenced this pull request Nov 3, 2026

Merge uikit/c01-8637-on-f2 (a60f08c: meta#8637 301c2ea on F2's meta#8360

2118c0c

df700c4) into the AlertDialog tracking base

vjeux added a commit to vjeux/astryx that referenced this pull request Nov 3, 2026

Merge the AlertDialog tracking base (7f26014: C01's meta#8637 helper a…

ddd6bef

…60f08c) into meta#8083

vjeux added a commit to vjeux/astryx that referenced this pull request Nov 3, 2026

Merge meta#8083 (ce7d87a: C01's meta#8637 helper a60f08c) into meta#8084

e352b3e

vjeux added a commit to vjeux/astryx that referenced this pull request Nov 3, 2026

Merge meta#8084 (eea74da: C01's meta#8637 helper a60f08c) into meta#8095

14b261d

vjeux added a commit to vjeux/astryx that referenced this pull request Nov 3, 2026

Merge uikit/c01-8637-on-f2 (e8bb92b: meta#8637 301c2ea on F2's fZ met…

f3672a7

…a#8360 23ade34) into the AlertDialog tracking base

vjeux added a commit to vjeux/astryx that referenced this pull request Nov 3, 2026

Merge the AlertDialog tracking base (0e0f1c2: F2's fZ meta#8360 23ade34…

5518668

…, C01's meta#8637 helper e8bb92b) into meta#8083

vjeux added a commit to vjeux/astryx that referenced this pull request Nov 3, 2026

Merge meta#8637 (ed3d750, on meta#8360 323a8fd) into the AlertDialog …

79fd1e9

…tracking base

vjeux added a commit to vjeux/astryx that referenced this pull request Nov 3, 2026

Merge the AlertDialog tracking base (meta#8360 323a8fd, meta#8637 ed3…

151cf4c

…d750) into meta#8083

vjeux added a commit to vjeux/astryx that referenced this pull request Nov 3, 2026

Merge meta#8083 (458e2d9, on meta#8360 323a8fd and meta#8637 ed3d750)…

0b619e4

… into meta#8084

vjeux force-pushed the uikit/c01-press-group-skip branch from ed3d750 to 071ae26 Compare November 3, 2026 22:59

vercel Bot deployed to Preview November 3, 2026 23:09

View deployment

astracat-bot Bot requested changes Nov 3, 2026

View reviewed changes

vjeux closed this Nov 3, 2026

vjeux deleted the uikit/c01-press-group-skip branch November 3, 2026 23:28

vjeux added a commit to vjeux/astryx that referenced this pull request Nov 3, 2026

Review base for meta#8657: and meta#8083 7f06866 (C18's fZ fold, with…

e0d3653

… the meta#8637 helper on fZ)

vjeux added a commit to vjeux/astryx that referenced this pull request Nov 3, 2026

Merge meta#8083 (458e2d9: AlertDialog's tracking on meta#8637 and met…

88076e6

…a#8360) into the ButtonGroup review base

vjeux added a commit to vjeux/astryx that referenced this pull request Nov 3, 2026

Merge meta#8084 (eea74da: C01's meta#8637 helper a60f08c) into the Al…

c16a257

…ertDialog hold

Navigation Menu

Repository navigation

chore(core): the press controller leaves an action group's tracked actions to its tracker - #8637

chore(core): the press controller leaves an action group's tracked actions to its tracker#8637
vjeux wants to merge 1631 commits into
meta:mainfrom
vjeux:uikit/c01-press-group-skip

vjeux commented Oct 27, 2026 •

edited

Loading

Uh oh!

astracat-bot Bot left a comment

Uh oh!

astracat-bot Bot Nov 3, 2026

Uh oh!

astracat-bot Bot Nov 3, 2026

Uh oh!

vjeux commented Nov 3, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

vjeux commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Maintainer impact

Intended invariant

Change

Evidence

Scope

Testing

Uh oh!

astracat-bot Bot left a comment

Choose a reason for hiding this comment

Uh oh!

astracat-bot Bot Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

astracat-bot Bot Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

vjeux commented Nov 3, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vjeux commented Oct 27, 2026 •

edited

Loading