Repository navigation
feat(ci): PR size report measures per-import JS and CSS and flags touch-only budget overruns #8296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7851d61
feat(ci): the PR size report measures per-import JS and CSS and flags…
cixzhang 49fbd93
fix(ci): the import figure bundles every module reached, package impo…
cixzhang bcb837b
fix(ci): component CSS counts only classes its own package modules re…
cixzhang 9766a0b
fix(ci): size every public component in a changed folder, family fold…
cixzhang 79d5be8
fix(ci): the import figure counts only eagerly loaded chunks; aliases…
cixzhang 89ec5a7
fix(ci): CSS counts classes from lazily loaded chunks too; aliases us…
cixzhang 8eb7e45
fix(ci): match own-package inputs by real path
cixzhang b5590d7
fix(ci): CSS counts only chunks the import can load; headers and foot…
cixzhang 111def4
fix(ci): size every component whose bundle reaches a changed module, …
cixzhang e69e323
fix(ci): decide reach in the merge-base build too and measure the union
cixzhang fbace5c
fix(ci): measure each tree through its own defining modules
cixzhang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ContextMenuItemis exported asDropdownMenuItem as ContextMenuItem(packages/core/src/ContextMenu/index.ts:21), so this passes a nameDropdownMenu/DropdownMenuItem.jsdoes not export; esbuild fails with “No matching export” and the row reads N/A in all six columns on every DropdownMenu change. Bundling the name the module exports (thesourceNamethatnamedExportItemsparses), or falling back toexport *, would give it figures.