Repository navigation
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-applied onto current main as one commit on #8080. The mouse fix this pull request first carried moved into #8080, whose review asked for it there. What stays is the placement the owner decided here, with its tests. It leaves draft with #8080 and #8458.
No behavior change. On every screen, a phone's included, the popover menu opens beside its trigger at the layer's placement; nothing centers it over the trigger.
Why
A phone menu placed over its trigger hides the control that opened it. This pull request first proposed that placement; the engineering owner decided here that the menu stays beside its trigger, so the placement was removed.
What led to it
Comparing our menus with UIKit's on the iOS 26.2 simulator, then the owner's review of the proposal.
Options and tradeoffs
Expected behavior and authority
The engineering owner's decision on this pull request: a phone menu keeps the layer's placement beside its trigger (the record amendment follows).
Evidence
Scope
Testing
On the DropdownMenu "Default" story, in a phone-sized window with touch emulation, open it from the top and from the bottom of the screen: it opens below its trigger and never covers it.
Automated: the two compact-touch cases in
DropdownMenu.test.tsxandDropdownMenuTouchPlacement(Chromium, WebKit). A[docs]changeset records the usage text.Local gates at 7292457: the DropdownMenu, Layer, Popover, motion and hooks units pass (2,537 of 2,537) and the core type check. The full gates are running.
Stack: #8627 → #8078 and #8186 → #8080 → this PR. Review only this PR's change: vjeux/astryx@127f876...7292457