Repository navigation
spec(AST-009): real-AT evidence never gates merge or release - #7915
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
|
/approve-spec 6b9105f |
PR Analysis ReportView Storybook for this PR · View Sandbox for this PR
Generated by PR Enrichment workflow | View current CI run |
There was a problem hiding this comment.
Changes requested: the AST-009 rewrite is owner-approved, but three current records outside this pull request still require screen-reader verification, which the new FR17 says no record may make a gate. Please reword them the way component:FieldStatus AR5 now reads (recommended real-AT follow-up, not a merge or release requirement) and list them in AST-009's Current-state impact:
docs/specs/AST-001/spec.md: the browser-evidence line (lines 76–78) and the FR7 verification row (line 110).packages/core/src/Table/plugins/rowStatus/useTableRowStatus.spec.md: AR6 (lines 217–218) and its AR1–AR6 verification row (line 262).packages/core/src/Table/plugins/columnResize/useTableColumnResize.spec.md: the FR8, AR1–AR3, AR6 verification row (line 237).
[Automated review]
| - `spec:AST-056`, `spec:AST-021`, `spec:AST-086`, and `component:FieldStatus` | ||
| stop describing real-AT receipts as a release boundary or a pending gate. |
There was a problem hiding this comment.
This list leaves out three current records that still require screen-reader verification, which FR17 now says no record may make a gate: docs/specs/AST-001/spec.md lines 76–78 and its FR7 verification row (line 110); useTableRowStatus.spec.md AR6 (lines 217–218) and its AR1–AR6 row (line 262); useTableColumnResize.spec.md line 237. Rewording them the way FieldStatus AR5 now reads, and naming them here, keeps the current records from contradicting each other.
…ate on screen-reader checks
|
/approve-spec bdd248c |
There was a problem hiding this comment.
This looks ready to approve: the AST-009 rewrite is owner-approved for this head, and the three records that still required screen-reader verification (AST-001, Table row status and Table column resize) now describe it as recommended follow-up, so no current record contradicts the new FR17. One follow-up sits outside this spec-only change: internal/a11y-spec/src/patterns/status-message.ts still says AST-009 requires a named real-AT matrix and durable receipts, and should be reworded once this lands.
[Automated review]
Exact decision needed
Whether merge or stable release may wait on real assistive-technology (NVDA, VoiceOver) evidence that contributors cannot produce.
Existing authority searched
spec:AST-009(current): FR4/FR8/FR17–FR19 required an explicit trigger classification, a named real-AT matrix, a scenario, and a durable release-block record, and blocked the first stable release until real-AT receipts passed or an owner exception applied.spec:AST-001(browser evidence and FR7 row),module:Table/useTableRowStatusAR6,module:Table/useTableColumnResizeverification,spec:AST-056(browser evidence line),spec:AST-021(release boundary phrase),spec:AST-086(FR6 real-AT row and platform line),component:FieldStatusAR5 and its verification row,spec:AST-020FR6 ("real-AT contract").Decision
Rejected alternatives
Claim scope and non-goals
Only the evidence bar for merge and release, and the status of real-AT observation. Component accessibility requirements, evidence-layer boundaries, and focus/announcement behavior stay with their owners.
Evidence and implementation relationship
Status-announcement conformance PRs (#7869, #7870, #7871, #7892, #7900, #7910) stall on the old real-AT release-block requirement because nobody in the review loop can run NVDA or VoiceOver. No implementation is included.
Writing rubric results
Scope
Validation
pnpm check:knowledgegit diff --check