Skip to content

test: the WebKit Carousel case reads the folder's specs from the tree - #10488

Merged
cixzhang merged 2 commits into
mainfrom
test/webkit-carousel-specs-from-tree
Nov 7, 2026
Merged

cixzhang merged 2 commits into
mainfrom
test/webkit-carousel-specs-from-tree

Conversation

@cixzhang

@cixzhang cixzhang commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Who this helps

Contributors who add a Carousel interaction spec no longer turn main's test-node red for everyone. The WebKit routing test listed Carousel's interaction specs by name. When two pull requests each added a Carousel spec, each passed on its own, and whichever merged second broke main, as happened once already.

What changes

.github/scripts/ci-interaction-webkit.test.mjs: the Carousel case reads the folder's interaction specs from the tree (listedSpecs, which the test already builds from the filesystem). It checks that a change to Carousel's own code plans exactly those specs, so a new Carousel spec needs no edit to this test. Test-only.

CI impact

None: no workflow, job, runner or required-context change.

Tests

Red-first, with a temporary extra file packages/core/src/Carousel/__tests__/ZzTemporary.interaction.browser.spec.ts:

  • main's literal list fails;
  • the derived case passes, both with the extra file and without it.

A literal list of Carousel's interaction specs broke main whenever two pull requests each added one. The case now compares the planner's selection with the folder's listed specs.
@vercel

vercel Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 7, 2026 11:24am UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 7, 2026
@astracat-bot

astracat-bot Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

AI review status for this pull request.

Review status Updated
🟢 Reviewed (for maintainers only) Nov 7, 2026, 11:26 AM UTC

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

PR Analysis Report

🔎 Preview · 3a20a96

Storybook · Sandbox · built from this PR's head

Package size: no published package changed; no new dependencies.

API changes: none in this pull request

Committed API report behind this build: cli 19 rows, core 25 rows; run pnpm api:report.

Not run on this PR: add ci:run-visual, ci:run-a11y or ci:run-rtl to run them.

CI impact: 0 job-min per update · pool 0% · time to green −1.3 min · standard runners · 1 CI action or script file changed (not measured)
Before After Change
Job-minutes per PR update 112.4 112.4 0
Runner pool, runner-minutes a day 58,103 58,103 0 (0%)
Average concurrent jobs 40.3 40.3 0
Time to green (median → this run) 17.1 min 15.8 min −1.3 min
Runs a day 517 517 0

Not measured (the jobs that use these keep their recent minutes above): .github/scripts/ci-interaction-webkit.test.mjs.

Assumptions: before is each job's average over the last 20 pull-request runs; after keeps that for unchanged jobs and uses this run's minutes for added or changed ones, weighted by how often each changed job ran in those runs; runs a day averages the seven whole days before today; time to green compares this run with the median of those runs that ran the same jobs.


Generated by PR Enrichment workflow | View full report

@astracat-bot astracat-bot Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending CI: some required checks are still running on this head.

The Carousel case now derives its expected interaction specs from the tree and still pins the planner's rule: a component's own code runs that folder's specs and no shared proof. With an extra, nested or removed Carousel spec the new case passes where the old literal list fails, and it still fails if the planner starts adding the shared proofs or drops a folder spec.

  • Non-blocking: the description and commit message say the list broke main "whenever two pull requests each added one", but the one break on record came from a pull request that added a spec while the list itself was landing (#10359 after #10225), so consider wording it that way.

[Automated review]

@cixzhang
cixzhang merged commit 89a9d2b into main Nov 7, 2026
101 of 104 checks passed
@cixzhang
cixzhang deleted the test/webkit-carousel-specs-from-tree branch November 7, 2026 11:48

This branch was successfully deployed

1 active deployment
Preview — 3a20a96b Deployed Nov 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant