Repository navigation
test: the WebKit Carousel case reads the folder's specs from the tree - #10488
Conversation
A literal list of Carousel's interaction specs broke main whenever two pull requests each added one. The case now compares the planner's selection with the folder's listed specs.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
PR Analysis Report🔎 Preview ·
|
| Before | After | Change | |
|---|---|---|---|
| Job-minutes per PR update | 112.4 | 112.4 | 0 |
| Runner pool, runner-minutes a day | 58,103 | 58,103 | 0 (0%) |
| Average concurrent jobs | 40.3 | 40.3 | 0 |
| Time to green (median → this run) | 17.1 min | 15.8 min | −1.3 min |
| Runs a day | 517 | 517 | 0 |
Not measured (the jobs that use these keep their recent minutes above): .github/scripts/ci-interaction-webkit.test.mjs.
Assumptions: before is each job's average over the last 20 pull-request runs; after keeps that for unchanged jobs and uses this run's minutes for added or changed ones, weighted by how often each changed job ran in those runs; runs a day averages the seven whole days before today; time to green compares this run with the median of those runs that ran the same jobs.
Generated by PR Enrichment workflow | View full report
There was a problem hiding this comment.
Approved pending CI: some required checks are still running on this head.
The Carousel case now derives its expected interaction specs from the tree and still pins the planner's rule: a component's own code runs that folder's specs and no shared proof. With an extra, nested or removed Carousel spec the new case passes where the old literal list fails, and it still fails if the planner starts adding the shared proofs or drops a folder spec.
- Non-blocking: the description and commit message say the list broke main "whenever two pull requests each added one", but the one break on record came from a pull request that added a spec while the list itself was landing (#10359 after #10225), so consider wording it that way.
[Automated review]
Who this helps
Contributors who add a Carousel interaction spec no longer turn
main'stest-nodered for everyone. The WebKit routing test listed Carousel's interaction specs by name. When two pull requests each added a Carousel spec, each passed on its own, and whichever merged second brokemain, as happened once already.What changes
.github/scripts/ci-interaction-webkit.test.mjs: the Carousel case reads the folder's interaction specs from the tree (listedSpecs, which the test already builds from the filesystem). It checks that a change to Carousel's own code plans exactly those specs, so a new Carousel spec needs no edit to this test. Test-only.CI impact
None: no workflow, job, runner or required-context change.
Tests
Red-first, with a temporary extra file
packages/core/src/Carousel/__tests__/ZzTemporary.interaction.browser.spec.ts:main's literal list fails;