You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(ci): include the Carousel snap-paging edge proof in WebKit routing - #10465
The WebKit routing unit test fails after #10359 adds CarouselSnapPagingEdges.interaction.browser.spec.ts. The planner correctly selects both Carousel interaction specs for a Carousel code change, but this test still expects only the original spec. That stale exact list makes the unit lane red despite correct routing.
Intended invariant
A component code change selects every interaction spec in its own folder and no shared proof. Preserve the existing routing contract and the change-scoped CI intent in AST-030 FR13. No behavior change.
Change
Add the new Carousel snap-paging edge proof to the exact expected list. This is one added test line; the planner, workflow, component code, and assertion strength are unchanged.
Replayed the exact failing test callback with Node's assertion equivalents, actual repository routing code, workflow values, and tracked spec files: failed 2/2 at that commit and 2/2 on freshly fetched main fa40f714868e9c41a8fcc4a0e516f075c72da0a2; passed 2/2 after the correction.
Additional routing checks pass: both Carousel proofs are selected; unrelated component and accessibility specs stay out; omitting the new proof or adding a shared proof still fails exact equality; a Carousel unit-test change selects no proofs.
node --check .github/scripts/ci-interaction-webkit.test.mjs and git diff --check pass.
Full Vitest, specs:for, and review:pre could not run: pnpm was unavailable and dependency installation failed authentication. The dependency-free callback replay is not a full Vitest run; CI must validate the complete suite.
Product/runtime behavior verified unchanged: only an expected test string is added.
CI impact: no job, runner class, runner-pool usage, or planned job-minute change.
Scope
No intended public API, product behavior, visual direction, or policy change.
No product changes included.
Public text contains no private operational context.
Fixes .github/scripts/ci-interaction-webkit.test.mjs › WebKit interaction proof routing › runs only the specs whose code its scope covers.
Package size: measured; main has no measurement of the merge base to compare yet.
API changes: none in this pull request
Committed API report behind this build: cli 19 rows, core 25 rows; run pnpm api:report.
Not run on this PR: add ci:run-visual, ci:run-a11y or ci:run-rtl to run them.
CI impact: 0 job-min per update · pool 0% · time to green −1.8 min · standard runners · 1 CI action or script file changed (not measured)
Before
After
Change
Job-minutes per PR update
112.4
112.4
0
Runner pool, runner-minutes a day
58,103
58,103
0 (0%)
Average concurrent jobs
40.3
40.3
0
Time to green (median → this run)
17.1 min
15.3 min
−1.8 min
Runs a day
517
517
0
Not measured (the jobs that use these keep their recent minutes above): .github/scripts/ci-interaction-webkit.test.mjs.
Assumptions: before is each job's average over the last 20 pull-request runs; after keeps that for unchanged jobs and uses this run's minutes for added or changed ones, weighted by how often each changed job ran in those runs; runs a day averages the seven whole days before today; time to green compares this run with the median of those runs that ran the same jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA SignedThis label is managed by the Meta Open Source bot.
0 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meta-cla
Bot
added
the
CLA Signed
Maintainer impact
The WebKit routing unit test fails after #10359 adds
CarouselSnapPagingEdges.interaction.browser.spec.ts. The planner correctly selects both Carousel interaction specs for a Carousel code change, but this test still expects only the original spec. That stale exact list makes the unit lane red despite correct routing.Intended invariant
A component code change selects every interaction spec in its own folder and no shared proof. Preserve the existing routing contract and the change-scoped CI intent in AST-030 FR13. No behavior change.
Change
Add the new Carousel snap-paging edge proof to the exact expected list. This is one added test line; the planner, workflow, component code, and assertion strength are unchanged.
Evidence
72a35585112edf5f98e16265898706640531574e(fix(Carousel): under snap paging, the edge buttons follow the held row #10359), unit-node 5/8, atci-interaction-webkit.test.mjs:289.fa40f714868e9c41a8fcc4a0e516f075c72da0a2; passed 2/2 after the correction.node --check .github/scripts/ci-interaction-webkit.test.mjsandgit diff --checkpass.specs:for, andreview:precould not run: pnpm was unavailable and dependency installation failed authentication. The dependency-free callback replay is not a full Vitest run; CI must validate the complete suite.Scope
Fixes
.github/scripts/ci-interaction-webkit.test.mjs › WebKit interaction proof routing › runs only the specs whose code its scope covers.See also #8125, #8133, #9814, and #9816.