Skip to content

test(Lightbox): split a long comment in the zoom busy proof - #10254

Draft
vjeux wants to merge 1 commit into
meta:mainfrom
vjeux:uikit/c13-zoom-proof-comment
Draft

vjeux wants to merge 1 commit into
meta:mainfrom
vjeux:uikit/c13-zoom-proof-comment

Conversation

@vjeux

@vjeux vjeux commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Maintainer impact

A test comment that #8148 added breaks the repository's comment rule (architecture:knowledge-contracts INV29: at most 25 words in a descriptive sentence). A reader of the Lightbox zoom's busy proof meets a 26-word sentence.

Intended invariant

INV29's sentence limit for source comments. No behavior change: the comment keeps its content and its place.

Change

  • packages/core/src/Lightbox/__tests__/LightboxZoom.interaction.browser.spec.ts: "Lightbox's own zoom played at tempo 3: each curve three times as long as at tempo 1, and still running on the compositor after the block." becomes two sentences, of 7 and 21 words: "Lightbox's own zoom played at tempo 3. Each curve runs three times as long as at tempo 1, and it still runs on the compositor after the block."

Evidence

  • Failure before the change: a sentence check over the file's comments, counting every word and number, finds this sentence at 26 words.
  • Success after the change: the same check finds no sentence over 25 words that this change touches.
  • Product/runtime behavior verified unchanged: git diff touches two comment lines in a browser test only.
  • CI impact: none; no workflow, action or CI script changes. No changeset: the changeset coverage check reports that nothing here ships to consumers.

Scope

  • No intended public API, product behavior, visual direction, or policy change.
  • Product changes discovered during the work were removed or split.
  • Public text and artifacts contain no internal Meta context.

Testing

Prettier, git diff --check and the changeset coverage check pass at this head.

The tempo-3 busy proof's comment ran one sentence to 26 words. It is
now two sentences, of 7 and 21 words, with the same content. Only the
comment changes.
@vercel

vercel Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 6, 2026 10:29am UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 6, 2026
@astracat-bot

astracat-bot Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

AI review status for this pull request.

Review status Updated
🟢 Reviewed (for maintainers only) Nov 6, 2026, 10:32 AM UTC

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

PR Analysis Report

Current run: The current CI run concluded skipped. Current analysis is unavailable.


Generated by PR Enrichment workflow | View current CI run

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending CI: CI has not run on this head yet. The pull request is still a draft from a fork, so mark it ready for review and have a maintainer add the ci:run label, which takes effect on the next push or a close and reopen.

The tempo-3 busy-proof comment (LightboxZoom.interaction.browser.spec.ts, lines 960-961) is now two sentences of 7 and 21 words. That is within the 25-word limit of architecture:knowledge-contracts INV29, and the content is unchanged. There are no blocking findings.

[Automated review]

This branch was successfully deployed

1 active deployment
Preview — b94c2c6b Deployed Nov 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant