Repository navigation
Conversation
The tempo-3 busy proof's comment ran one sentence to 26 words. It is now two sentences, of 7 and 21 words, with the same content. Only the comment changes.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
PR Analysis Report
Generated by PR Enrichment workflow | View current CI run |
There was a problem hiding this comment.
Approved pending CI: CI has not run on this head yet. The pull request is still a draft from a fork, so mark it ready for review and have a maintainer add the ci:run label, which takes effect on the next push or a close and reopen.
The tempo-3 busy-proof comment (LightboxZoom.interaction.browser.spec.ts, lines 960-961) is now two sentences of 7 and 21 words. That is within the 25-word limit of architecture:knowledge-contracts INV29, and the content is unchanged. There are no blocking findings.
[Automated review]
Maintainer impact
A test comment that #8148 added breaks the repository's comment rule (
architecture:knowledge-contractsINV29: at most 25 words in a descriptive sentence). A reader of the Lightbox zoom's busy proof meets a 26-word sentence.Intended invariant
INV29's sentence limit for source comments. No behavior change: the comment keeps its content and its place.
Change
packages/core/src/Lightbox/__tests__/LightboxZoom.interaction.browser.spec.ts: "Lightbox's own zoom played at tempo 3: each curve three times as long as at tempo 1, and still running on the compositor after the block." becomes two sentences, of 7 and 21 words: "Lightbox's own zoom played at tempo 3. Each curve runs three times as long as at tempo 1, and it still runs on the compositor after the block."Evidence
git difftouches two comment lines in a browser test only.Scope
Testing
Prettier,
git diff --checkand the changeset coverage check pass at this head.