Repository navigation
test(CommandPalette): match the current Spinner progressbar role - #10175
Closed
astracat-bot[bot] wants to merge 2 commits into
Closed
astracat-bot[bot] wants to merge 2 commits into
astracat-bot[bot] wants to merge 2 commits into
Conversation
astracat-bot
Bot
requested review from
cixzhang,
imdreamrunner and
josephfarina
as code owners
November 5, 2026 23:34
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
AI review status for this pull request.
|
Contributor
PR Analysis Report🔎 Preview ·
|
…current-spinner-progressbar-role-953366
3 tasks done
imdreamrunner
approved these changes
Nov 6, 2026
Contributor
Author
github-actions
Bot
deleted the
codebunny/fix/test-commandpalette-match-the-current-spinner-progressbar-role-953366
branch
November 6, 2026 06:04
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer impact
All six CommandPalette audit captures fail before screenshots or semantic sensors run: the pending palette's
.astryx-spinner[role="status"]locator finds zero elements instead of one. Spinner's role changed toprogressbarin #7910, but this consumer assertion still queries the old role.Intended invariant
The current Spinner contract, AR1 and the compatibility table, requires
role="progressbar"for every indicator, including hidden composed rings. CommandPalette delegates its loading indicator to Spinner under its FR3 contract.Change
Change only the shared capture locator from
statustoprogressbar. Keep the exact count of one and every existing geometry, contrast, anatomy, and screenshot check. The CSS locator remains appropriate because CommandPalette deliberately hides its composed spinner witharia-hidden.No behavior change. No remaining uncertainty about the expected role; restoring
statusin the component would contradict the current Spinner contract.Evidence
captures narrow-lightin Chromium with the exact CI failure at line 139: expected 1, received 0.wide-light-ltr,wide-dark-ltr,wide-light-rtl,wide-dark-rtl,narrow-light, andnarrow-dark(7.2 seconds).CommandPaletteInput.test.tsxtests pass.eaea67de3568bde61072c901f1e9713fe19b0ce4, apart from this assertion.Scope
Testing
Using the repository-pinned Node.js 24.22.1 and pnpm 11.10.0:
pnpm storybook:buildpnpm exec playwright test packages/core/src/CommandPalette/__tests__/CommandPalette.a11y.chromium.spec.ts --config=playwright.config.ts --project=chromiumpnpm exec vitest run --project ui packages/core/src/CommandPalette/CommandPaletteInput.test.tsx --maxWorkers=1pnpm specs:for --diff origin/mainpnpm review:pre— no findings; self-review only, independent review still needed.git diff --checkpass.