Skip to content

test(CommandPalette): match the current Spinner progressbar role - #10175

Closed
astracat-bot[bot] wants to merge 2 commits into
mainfrom
codebunny/fix/test-commandpalette-match-the-current-spinner-progressbar-role-953366
Closed

astracat-bot[bot] wants to merge 2 commits into
mainfrom
codebunny/fix/test-commandpalette-match-the-current-spinner-progressbar-role-953366

Conversation

@astracat-bot

@astracat-bot astracat-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Maintainer impact

All six CommandPalette audit captures fail before screenshots or semantic sensors run: the pending palette's .astryx-spinner[role="status"] locator finds zero elements instead of one. Spinner's role changed to progressbar in #7910, but this consumer assertion still queries the old role.

Intended invariant

The current Spinner contract, AR1 and the compatibility table, requires role="progressbar" for every indicator, including hidden composed rings. CommandPalette delegates its loading indicator to Spinner under its FR3 contract.

Change

Change only the shared capture locator from status to progressbar. Keep the exact count of one and every existing geometry, contrast, anatomy, and screenshot check. The CSS locator remains appropriate because CommandPalette deliberately hides its composed spinner with aria-hidden.

No behavior change. No remaining uncertainty about the expected role; restoring status in the component would contradict the current Spinner contract.

Evidence

  • Before: reproduced captures narrow-light in Chromium with the exact CI failure at line 139: expected 1, received 0.
  • After: all six captures pass: wide-light-ltr, wide-dark-ltr, wide-light-rtl, wide-dark-rtl, narrow-light, and narrow-dark (7.2 seconds).
  • Representative unchanged path: all 46 CommandPaletteInput.test.tsx tests pass.
  • The Storybook fixture, audit test file, and Spinner implementation are unchanged between the first bad commit and the tested base, eaea67de3568bde61072c901f1e9713fe19b0ce4, apart from this assertion.

Scope

  • No intended public API, product behavior, visual direction, or policy change.
  • No unrelated product changes.
  • Public text and artifacts contain no private operational context.

Testing

Using the repository-pinned Node.js 24.22.1 and pnpm 11.10.0:

  • pnpm storybook:build
  • pnpm exec playwright test packages/core/src/CommandPalette/__tests__/CommandPalette.a11y.chromium.spec.ts --config=playwright.config.ts --project=chromium
  • pnpm exec vitest run --project ui packages/core/src/CommandPalette/CommandPaletteInput.test.tsx --maxWorkers=1
  • pnpm specs:for --diff origin/main
  • pnpm review:pre — no findings; self-review only, independent review still needed.
  • Targeted Prettier and ESLint checks, and git diff --check pass.

@vercel

vercel Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 6, 2026 1:05am UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 5, 2026
@astracat-bot

astracat-bot Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor Author

AI review status for this pull request.

Review status Updated
🟢 Reviewed (for maintainers only) Nov 6, 2026, 1:08 AM UTC

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

PR Analysis Report

🔎 Preview · 1142e56

Storybook · Sandbox · built from this PR's head

Current run: The current CI run concluded cancelled. Current analysis is unavailable.


Generated by PR Enrichment workflow | View current CI run

@cixzhang cixzhang added the ci:run-a11y Run the accessibility suite on this PR; write access, next push (AST-030 FR12) label Nov 6, 2026
@astracat-bot

astracat-bot Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

Closing: every test this PR fixes passes on main without it, fixed on main by 8ee380b (#10196).

@astracat-bot astracat-bot Bot closed this Nov 6, 2026
@github-actions
github-actions Bot deleted the codebunny/fix/test-commandpalette-match-the-current-spinner-progressbar-role-953366 branch November 6, 2026 06:04

This branch was successfully deployed

1 active deployment
Preview — 1142e56a Deployed Nov 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:run-a11y Run the accessibility suite on this PR; write access, next push (AST-030 FR12) CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants