feat(lab): DialogHeroHeader showcase, and astryx discover lists it by cixzhang · Pull Request #10109 · meta/astryx

cixzhang · 2026-11-05T16:34:42Z

Part 3 of 3 of the carry that supersedes #5105 (jiunshinn's DialogHeroHeader). It stacks on #10108 (the Lab component), which stacks on #10105 (Core). It carries jiunshinn's showcase and discover entries on a team branch, with a Co-authored-by trailer.

User impact

A builder browsing the Lab showcases, or running astryx discover, finds DialogHeroHeader and a working example to copy.

What is in this PR

packages/lab/blocks/DialogHeroHeaderShowcase.tsx and its .doc.mjs.
packages/cli/assets/discover/official-packages.json: the DialogHeroHeader and showcase entries.
internal/shadcn-registry/routes.lock.json: the showcase route.
.changeset/…dhhr.md: names @astryxdesign/cli for the discover entries (credits jiunshinn).

Authority

Lab under the design owner's Lab grant.

Testing

pnpm check:changesets; eslint on the showcase.
Size: 5 files, +134.

vercel · 2026-11-05T16:34:46Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
astryx	Ready	Preview	Nov 6, 2026 5:19am UTC

astracat-bot · 2026-11-05T16:34:52Z

AI review status for this pull request.

Review status	Updated
🟢 Reviewed (for maintainers only)	Nov 6, 2026, 5:30 AM UTC

cixzhang · 2026-11-05T16:36:06Z

/approve-spec f8ad635

astracat-bot

Changes requested: the showcase block, the discover entries and the route-lock entry line up with what the generators produce, but the new block loses keyboard focus.

packages/lab/blocks/DialogHeroHeaderShowcase.tsx unmounts the focused button on Close (line 57), Get started (line 73) and Preview welcome dialog (line 83), so keyboard focus falls to the page body each time; keep the preview static like Core's DialogHeaderShowcase, or have the click handler mark that focus should move and focus the replacing control from a callback ref.

The discover list matches its generator, the block clears the Lab package's missing-example note for DialogHeroHeader, and the route-lock entry matches the registry's derived name.

[Automated review]

astracat-bot · 2026-11-05T16:56:18Z

+  return isOpen ? (
+    <Dialog isOpen isInline onOpenChange={setIsOpen}>


Each transition here unmounts the button that holds focus: Close (line 57), Get started (line 73) and Preview welcome dialog (line 83). In Chromium, after pressing Enter on any of them, focus is on the page body, so a keyboard user loses their place. Core's DialogHeaderShowcase keeps a static preview with a no-op onOpenChange. Alternatively, keep the toggle, have the click handler mark that focus should move, and focus the replacing control from its callback ref.

cixzhang · 2026-11-05T21:39:32Z

/approve-spec 853fdc2

astracat-bot

Changes requested: the showcase now stays open, so keyboard focus stays on the pressed button, and the discover and route-lock entries match what the generators derive. One wording fix is left.

Regression: the changeset (.changeset/astryx-discover-lists-the-lab-dialogheroheader-c-dhhr.md, line 5) says astryx discover now lists the DialogHeroHeader component, but that entry moved into #10108 when its branch was rebuilt, so word this changeset for the DialogHeroHeaderShowcase template alone and give the component line its own @astryxdesign/cli changeset in #10108, as the CircleCheckIndicator change did.

The description's file list and size still describe the earlier revision and need the same update.

[Automated review]

astracat-bot · 2026-11-05T21:58:01Z

+'@astryxdesign/cli': patch
+---
+
+[feat] `astryx discover` lists the Lab DialogHeroHeader component and its DialogHeroHeaderShowcase template from `@astryxdesign/lab`. (#4182)


Regression: this pull request now adds only the DialogHeroHeaderShowcase template entry to official-packages.json; the DialogHeroHeader component entry moved into #10108 when its branch was rebuilt. Word this note for the template alone, for example "astryx discover lists DialogHeroHeaderShowcase, the showcase template for the Lab DialogHeroHeader, from @astryxdesign/lab.", and give the component line its own @astryxdesign/cli changeset in #10108.

cixzhang · 2026-11-06T05:04:34Z

/approve-spec 33bc8cb

Carries jiunshinn's showcase block and doc, the official package index entries, and the CLI changeset from #5105. Co-authored-by: jiunshinn <jiun.dev@gmail.com>

…lls to the page; the Showcase story comes with its block

…component's entry ships with #10108

cixzhang · 2026-11-06T05:13:56Z

/approve-spec 2672f94

astracat-bot

Approved pending CI: CI has not run on this head yet, because a draft pull request on this branch runs no CI workflow.

The changeset now describes only the DialogHeroHeaderShowcase template this pull request adds, the showcase keeps keyboard focus on the pressed button, and the discover and route-lock entries match what their generators derive.

Non-blocking: the description still lists "the DialogHeroHeader and showcase entries" for the discover file and "5 files, +134"; this pull request now adds only the showcase entry, across 6 files (+127) including the Storybook story.

[Automated review]

meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 5, 2026

vercel Bot deployed to Preview November 5, 2026 16:43

View deployment

astracat-bot Bot requested changes Nov 5, 2026

View reviewed changes

cixzhang force-pushed the carry/dialog-hero-header branch from 9a05f56 to 71eff45 Compare November 5, 2026 21:37

cixzhang force-pushed the carry/dialog-hero-header-showcase branch from f8ad635 to 853fdc2 Compare November 5, 2026 21:38

vercel Bot deployed to Preview November 5, 2026 21:48

View deployment

astracat-bot Bot mentioned this pull request Nov 5, 2026

feat(lab): DialogHeroHeader #10108

Draft

astracat-bot Bot requested changes Nov 5, 2026

View reviewed changes

cixzhang force-pushed the carry/dialog-hero-header branch from 71eff45 to 786ed9e Compare November 6, 2026 05:02

cixzhang force-pushed the carry/dialog-hero-header-showcase branch from 853fdc2 to 33bc8cb Compare November 6, 2026 05:03

vercel Bot deployed to Preview November 6, 2026 05:11

View deployment

cixzhang force-pushed the carry/dialog-hero-header branch from 786ed9e to 25a3e5d Compare November 6, 2026 05:12

cixzhang and others added 3 commits November 5, 2026 21:12

feat(lab): DialogHeroHeader showcase, and astryx discover lists it

bfa762c

Carries jiunshinn's showcase block and doc, the official package index entries, and the CLI changeset from #5105. Co-authored-by: jiunshinn <jiun.dev@gmail.com>

fix(lab): the DialogHeroHeader showcase stays open, so focus never fa…

6b4a9df

…lls to the page; the Showcase story comes with its block

chore(cli): the showcase PR's changeset lists only the template; the …

2672f94

…component's entry ships with #10108

cixzhang force-pushed the carry/dialog-hero-header-showcase branch from 33bc8cb to 2672f94 Compare November 6, 2026 05:12

vercel Bot deployed to Preview November 6, 2026 05:19

View deployment

astracat-bot Bot approved these changes Nov 6, 2026

View reviewed changes

Navigation Menu

Repository navigation

feat(lab): DialogHeroHeader showcase, and astryx discover lists it - #10109

feat(lab): DialogHeroHeader showcase, and astryx discover lists it#10109
cixzhang wants to merge 3 commits into
carry/dialog-hero-headerfrom
carry/dialog-hero-header-showcase

cixzhang commented Nov 5, 2026

Uh oh!

vercel Bot commented Nov 5, 2026 •

edited

Loading

Uh oh!

astracat-bot Bot commented Nov 5, 2026 •

edited

Loading

Uh oh!

cixzhang commented Nov 5, 2026

Uh oh!

astracat-bot Bot left a comment

Uh oh!

astracat-bot Bot Nov 5, 2026

Uh oh!

cixzhang commented Nov 5, 2026

Uh oh!

astracat-bot Bot left a comment •

edited

Loading

Uh oh!

astracat-bot Bot Nov 5, 2026

Uh oh!

cixzhang commented Nov 6, 2026

Uh oh!

cixzhang commented Nov 6, 2026

Uh oh!

astracat-bot Bot left a comment

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		return isOpen ? (
		<Dialog isOpen isInline onOpenChange={setIsOpen}>

Conversation

cixzhang commented Nov 5, 2026

User impact

What is in this PR

Authority

Testing

Uh oh!

vercel Bot commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

astracat-bot Bot commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cixzhang commented Nov 5, 2026

Uh oh!

astracat-bot Bot left a comment

Choose a reason for hiding this comment

Uh oh!

astracat-bot Bot Nov 5, 2026

Choose a reason for hiding this comment

Uh oh!

cixzhang commented Nov 5, 2026

Uh oh!

astracat-bot Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

astracat-bot Bot Nov 5, 2026

Choose a reason for hiding this comment

Uh oh!

cixzhang commented Nov 6, 2026

Uh oh!

cixzhang commented Nov 6, 2026

Uh oh!

astracat-bot Bot left a comment

Choose a reason for hiding this comment

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Nov 5, 2026 •

edited

Loading

astracat-bot Bot commented Nov 5, 2026 •

edited

Loading

astracat-bot Bot left a comment •

edited

Loading