Repository navigation
Conversation
…n a phone A non-exported Core harness, PresentedHitTestingLab, that Storybook renders as Core/Gestures "Presented hit testing": a sheet springs up over a full-page scrim on a slowed spring, with Done in the sheet and a scrolling page behind it, and reads out what the engine hit-tested at each touch-down. A native checkbox turns the gesture host's correction off as the control. Co-authored-by: Cindy Zhang <cindyxz@meta.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Analysis Report
Generated by PR Enrichment workflow | View current CI run |
|
AI review status for this pull request.
|
There was a problem hiding this comment.
Approved pending CI: CI has not run on this head yet because the pull request is a draft, and it starts once the pull request is marked ready for review.
The harness and story are test tooling only, with nothing exported or shipped. spec:AST-094 lets the real-device evidence for presented hit testing follow merge, so the iPhone run is the next step rather than a condition here. The corrected-tap test is a real guard: it fails when the harness host is forced to presentedHitTesting: 'never'.
[Automated review]
Supersedes #9400 by @vjeux: the same three files, rebuilt as one commit on today's
mainwith his authorship. Its intermediate docsite commit conflicts withmainand was replaced within the branch, so the net change is unchanged. Harness and story only: no library code, no API, and no changeset.Maintainer impact
Presented hit testing (
spec:AST-094FR11, FR19) is proven in CI's WebKit lane and in the iOS Simulator. But no story, sandbox or docs page attaches the gesture host, so a phone that opens a preview cannot exercise it. A check on a physical iPhone needs a page that does.Intended invariant
spec:AST-017FR21 andarchitecture:react-component-runtimeINV13: Core's internal entries and gesture source stay with Core and Lab. This pull request adds no import of them from outside Core. The harness is a Core file, and the story renders it the way the a11y stories render Core's__tests__renderings.Change
packages/core/src/__tests__/PresentedHitTestingLab.tsx(not exported): a sheet springs up over a full-page scrim on a spring slowed to a 3 s response, with Done in the sheet and a page behind it that scrolls.PresentedHitTestingLab.test.tsx: its unit test (3 cases).apps/storybook/stories/PresentedHitTestingLab.stories.tsx: one full-screen story, "Presented hit testing" under "Core/Gestures".Evidence