Repository navigation
chore: regenerate the four core API report rows three merges left stale - #10056
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
|
AI review status for this pull request.
|
PR Analysis Report🔎 Preview ·
|
![astracat-bot[bot]](https://avatars.githubusercontent.com/in/4796231?s=60&v=4){kind=small}
There was a problem hiding this comment.
Changes requested: one commit-message fix.
- Miss: the only commit is still titled
chore: regenerate the core API report rows four merges left stale, and a squash merge of a single-commit pull request lands under that subject rather than the corrected title, so please reword the commit tochore: regenerate the four core API report rows three merges left staleand push.
The four rows match what pnpm api:report generates for this head, and no public API or behavior changes. CI has not run on this head: it is a draft from a fork, so it runs once it is marked ready and a maintainer adds the ci:run label.
[Automated review]
|
/approve-spec 5571c8d |
vjeux
changed the title
Only packages/core/api-report.md changes, as pnpm api:report writes it on main bfc1dcc: useClickableContainer's parameter spelling (meta#8085), the colorVars and inputWrapperStyles hashes after the dark-mode accent change (meta#9818), and the array spelling of visibleCalendarMonths (meta#10007).
5571c8d to
1cb3ee6
Compare
|
Reworded in 1cb3ee6: the commit is now titled |
There was a problem hiding this comment.
Approved pending CI: CI has not run on this head yet.
The four rows now match what pnpm api:report generates, both at this head and on current main, and the commit subject now matches the title. This is a draft from a fork, so CI runs once it is marked ready for review and a maintainer adds the ci:run label.
- Current
mainhas since picked up other stale core rows (the component icon slot types and Item's target states); they are outside this change and can go in a follow-up.
[Automated review]
cixzhang
added
the
ci:run
|
/approve-spec 1cb3ee6 |
1 similar comment
|
/approve-spec 1cb3ee6 |
Maintainer impact
pnpm api:report --checkreportspackages/core/api-report.mdas stale on main. A pull request that regenerates the report for its own change also picks up these unrelated rows. Its report diff then carries rows it did not decide, and reviewers must tell them apart.Intended invariant
Each committed API report equals what
pnpm api:reportgenerates from the current build. Every row here records a change that main already merged. None of them changes the public API.Change
Only the generated core report changes, as
pnpm api:reportwrites it on main bfc1dcc. Four rows, from three merges:useClickableContainer: feat(List): a row's touch target grows toward 44 px where its neighbors leave room #8085 changed its parameter from a destructured object tooptions: UseClickableContainerOptions. The type stays the same, and the row now prints(options: …).colorVars: fix(theme): the stock theme's dark-mode accent is darker, so white button text meets 4.5:1 #9818 darkened the dark-mode accent to#0171E3. It updated the row's visible value but kept the earlier hash,#a042f923. The row now ends in#9de1262f.inputWrapperStyles: its type embedscolorVars['--color-accent']. So the same accent change moves its hash from#90a96087to#ba795170. No input style changed.UseCalendarNavigationReturn.visibleCalendarMonths: feat(Calendar): useCalendarDays and useCalendarNavigation take an optional calendar #10007 added the member and wrote its row asArray<{ year: number; month: number }>. The source and the generator spell it{ year: number; month: number }[].No source, test, record or changeset changes. The CLI report is stale on main too. Its rows wait for their record, as in #9986, so this pull request leaves that file as it is.
Evidence
pnpm build,pnpm api:report --checkexits 1. It listspackages/core/api-report.mdand the CLI report.#2694FErestored locally, the generator writes#a042f923and#90a96087again.packages/core/api-report.mdchanges, and it does not ship.Scope
Testing
pnpm install --frozen-lockfile,pnpm build, thenpnpm api:report, whose core output is this file.pnpm api:report --checklists the core report on main and not here; it still lists the CLI report. The accent counterfactual was an uncommitted local edit; after restoring it, a rebuild regenerated this file byte for byte. Alsopnpm check:changesets, Prettier on the report, andreview:pre(no findings). Of the 14 open pull requests that edit this report, none edits these four rows.No behavior change.