Repository navigation
docs(BottomSheet): AST-094 names FR18's caller-sized exception; a comment names the pen - #10023
Merged
Merged
Conversation
…ment names the pen AST-094's BottomSheet line said that every finger's pull past the tallest detent stretches the sheet over a reserve deep enough for the whole stretch. A sheet the caller sizes or styles keeps 48 px below the screen instead, and its stretch stops there (`component:BottomSheet` FR18). The line now says so. The comment on OVERSCROLL_RESISTANCE named only the mouse. A pen's stretch past fully open uses the same resisted fraction, and the comment now names it. A [docs] Changeset covers the comment.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
github-actions
Bot
added
the
needs:spec-owner-review
Contributor
|
AI review status for this pull request.
|
Contributor
PR Analysis Report🔎 Preview ·
|
| Component | Size | LoC | Visual · A11y · RTL |
|---|---|---|---|
| BottomSheet | 56.3 kB (0) · 7.5 kB CSS (0) | — | ✓ · ✓ · — |
| BottomSheetSwitcher | 17.4 kB (0) · 3.4 kB CSS (0) | — | ✓ · ✓ · — |
| ContextMenu | 81.8 kB (0) · 16.0 kB CSS (0) | — | — · — · — |
22 more components
| Component | Size | LoC | Visual · A11y · RTL |
|---|---|---|---|
| DateInput | 154.9 kB (0) · 15.5 kB CSS (0) | — | — · — · — |
| DateTimeInput | 177.0 kB (0) · 17.2 kB CSS (0) | — | — · — · — |
| DropdownMenu | 77.3 kB (0) · 16.1 kB CSS (0) | — | — · — · — |
| Markdown | 152.3 kB (0) · 18.9 kB CSS (0) | — | — · — · — |
| MoreMenu | 77.6 kB (0) · 16.1 kB CSS (0) | — | — · — · — |
| MultiSelector | 79.5 kB (0) · 15.5 kB CSS (0) | — | — · — · — |
| Pagination | 92.4 kB (0) · 16.5 kB CSS (0) | — | — · — · — |
| Popover | 55.1 kB (0) · 12.8 kB CSS (0) | — | — · — · — |
| PowerSearch | 249.5 kB (0) · 22.3 kB CSS (0) | — | — · — · — |
| Selector | 82.3 kB (0) · 16.1 kB CSS (0) | — | — · — · — |
| Table | 91.2 kB (0) · 16.7 kB CSS (0) | — | — · — · — |
| TableCell | 83.0 kB (0) · 16.5 kB CSS (0) | — | — · — · — |
| TableHeaderCell | 82.6 kB (0) · 16.2 kB CSS (0) | — | — · — · — |
| TimeInput | 140.4 kB (0) · 14.5 kB CSS (0) | — | — · — · — |
| Tokenizer | 73.8 kB (0) · 17.1 kB CSS (0) | — | — · — · — |
| lab/ChatEmojiPicker | 68.9 kB (0) · 773 B CSS (0) | — | — · — · — |
| lab/ChatReactionBar | 69.4 kB (0) · 1.1 kB CSS (0) | — | — · — · — |
| lab/CommentComposer | 108.6 kB (0) · 1.9 kB CSS (0) | — | — · — · — |
| lab/Comments | 271.3 kB (0) · 2.5 kB CSS (0) | — | — · — · — |
| lab/CommentThread | 266.2 kB (0) · 2.4 kB CSS (0) | — | — · — · — |
| lab/TourStep | 61.1 kB (0) · 590 B CSS (0) | — | — · — · — |
| richtext/RichTextEditorToolbar | 232.9 kB (0) · 454 B CSS (0) | — | — · — · — |
Package size: @astryxdesign/core 6.49 MB packed (−2 B); no new dependencies.
API changes: none in this pull request
Committed API report behind this build: cli 9 rows, core 3 rows; run pnpm api:report.
Touched components checked; add ci:run-visual, ci:run-a11y or ci:run-rtl to run the full suites.
Generated by PR Enrichment workflow | View full report
Contributor
|
/approve-spec ea87f86 |
github-actions
Bot
removed
the
needs:spec-owner-review
![astracat-bot[bot]](https://avatars.githubusercontent.com/in/4796231?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Approved pending CI: the required checks are still running on this head.
The AST-094 BottomSheet line now names component:BottomSheet FR18's exception for a sheet the caller sizes or styles, and the OVERSCROLL_RESISTANCE comment names the pen, which the non-touch branch already serves. Both match the current records, and nothing a consumer imports or renders changes.
[Automated review]
vjeux
marked this pull request as ready for review
November 5, 2026 01:17
vjeux
requested review from
cixzhang,
imdreamrunner and
josephfarina
as code owners
November 5, 2026 01:17
cixzhang
added
the
ci:run
cixzhang
marked this pull request as draft
November 5, 2026 01:19
cixzhang
marked this pull request as ready for review
November 5, 2026 01:19
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reader impact
AST-094's BottomSheet line said that every finger's pull past the tallest detent stretches the sheet over a reserve deep enough for the whole stretch. It left out
component:BottomSheetFR18's exception, so a reader of AST-094 alone expects that reserve on every sheet. A source comment also named only the mouse for the resisted stretch that a pen gets too.No behavior change.
Source of truth
component:BottomSheetFR18: "A sheet the caller sizes or styles keeps 48 px below the screen, and its stretch stops there."useSheetGestures.ts: a pull that is not a touch, a mouse's or a pen's, stretches past fully open byraw * OVERSCROLL_RESISTANCE, capped atOVERSCROLL_MAX.Correction
component:BottomSheetFR18)" after the reserve. The rest of the line is unchanged, and its paragraph is re-wrapped.OVERSCROLL_RESISTANCEcomment reads "A mouse's or a pen's stretch past fully open".[docs]Changeset covers the comment, as the repository's other comment-only changes do.Evidence
Both are non-blocking notes from the automated review of #8109, which merged with them as follow-ups.
Writing rubric results
Scope
Testing
Local, at ea87f86 on
mainbb7702c:pnpm check:knowledge, Prettier andgit diff --checkon the three files,pnpm linton the source file (no errors), the Changeset coverage check, andpnpm review:pre(0 findings).