Skip to content

ci: restrict Develocity cache writes to trusted events #6550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesarich merged 1 commit into from
Aug 3, 2026
Merged

ci: restrict Develocity cache writes to trusted events #6550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion build-logic/settings-plugin/src/main/kotlin/MeshtasticDevelocitySettingsPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,14 @@ class MeshtasticDevelocitySettingsPlugin : Plugin<Settings> {
remote(develocity.buildCache) {
isEnabled = true
val accessKey = System.getenv("DEVELOCITY_ACCESS_KEY")?.trim()
isPush = isCI && !accessKey.isNullOrEmpty()
// Write only from trusted events. A same-repository pull request DOES
// receive repository secrets, so gating on the access key alone let PR
// builds write into the shared cache; excluding pull_request here keeps
// unmerged code out of it. Fork PRs have no key and are excluded twice
// over, and local builds are excluded by isCI.
val event = System.getenv("GITHUB_EVENT_NAME")
val trustedForPush = event == "push" || event == "merge_group"
isPush = isCI && trustedForPush && !accessKey.isNullOrEmpty()
}
}
}
Expand Down
Loading