Skip to content

fix: categorize Stellar Horizon query failures - #854

Merged
Cjay-Cyber-2 merged 1 commit into
mergepay:mainfrom
Hikmaholadele:feat/stellar-horizon-refactor
Oct 19, 2026
Merged

Cjay-Cyber-2 merged 1 commit into
mergepay:mainfrom
Hikmaholadele:feat/stellar-horizon-refactor

Conversation

@Hikmaholadele

Copy link
Copy Markdown
Contributor

Summary

  • Normalize exhausted Horizon query failures into typed provider categories while preserving timeout and transport semantics.
  • Log safe Pino diagnostics for final failures, including operation, category, and sanitized Horizon result codes.
  • Cover provider error normalization and transaction rejection behavior in the existing Horizon service tests.

Validation

  • npm run build passes.
  • Focused Horizon tests pass (46 tests).
  • Full npm test: 4,168 passed, 22 skipped; two unrelated 5-second timeout tests failed under parallel-suite load and passed when rerun alone.

Closes #683

@drips-wave

drips-wave Bot commented Oct 19, 2026

Copy link
Copy Markdown

@Hikmaholadele Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Cjay-Cyber-2 Cjay-Cyber-2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — approving.

@Cjay-Cyber-2 Cjay-Cyber-2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — approving.

@Cjay-Cyber-2
Cjay-Cyber-2 merged commit b1282f6 into mergepay:main Oct 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Stellar Horizon service layer for robust error handling and timeout management

2 participants