Skip to content

Review tab counts untracked files - #598

Merged
jamescrosswell merged 1 commit into
mainfrom
milestone-597-review-untracked
Oct 23, 2026
Merged

jamescrosswell merged 1 commit into
mainfrom
milestone-597-review-untracked

Conversation

@a-team-app

@a-team-app a-team-app Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

The Review tab now lists untracked files git doesn't ignore, compared with the merge base (or the PR's base) like any other file. A new file you haven't added shows as A with its +N, an untracked file that differs from the base shows as M, and restoring a committed deletion and saving it takes it off the list after a refresh. Nothing is staged: the diff runs against a throwaway copy of the index.

Closes #597

Worth knowing:

  • Rename detection (-M) now also pairs a deleted file with an untracked one that's similar enough, so an unstaged mv shows as R rather than D plus A. The task left this out of scope, expecting D and A; I kept -M as it was rather than turning it off for untracked files only.
  • Locally the full suite passed 3,054 tests with none failing, then hung in EditorTabDirtyTests (Ctrl+K, the clipboard path), which this change doesn't touch.

🤖 Generated with Claude Code

a-team try tuicode 598

GetChangedFilesAsync and GetLineCountsAsync diff against a throwaway copy
of the index with every untracked, not-ignored file added as
intent-to-add (GIT_INDEX_FILE), so those files compare with the merge
base like tracked ones: a restored deletion identical to the base drops
off, a new file shows as added with its line count, and the user's
index is never written.

Closes #597

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@a-team-app
a-team-app Bot marked this pull request as ready for review October 23, 2026 11:13
@jamescrosswell
jamescrosswell merged commit c534098 into main Oct 23, 2026
30 checks passed
@jamescrosswell
jamescrosswell deleted the milestone-597-review-untracked branch October 23, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review tab counts untracked files, so a restored file leaves it and a new file shows

1 participant