Skip to content

Pickers and prompts show their keys on buttons, F1 lists the rest, and the arrows choose - #596

Merged
jamescrosswell merged 1 commit into
mainfrom
milestone-572-picker-keys
Oct 23, 2026
Merged

jamescrosswell merged 1 commit into
mainfrom
milestone-572-picker-keys

Conversation

@a-team-app

@a-team-app a-team-app Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Open recent folder, Definitions of, Choose grammar, Go to line and the language server dialog now show their keys on buttons (Enter Open / Enter Go to / Enter Choose / Ctrl+Enter Save, and Esc Cancel). They no longer have hint rows. F1 in any of them opens Help titled with the dialog, listing its keys, and Esc goes back with the filter, caret and selected row as they were. The pickers say a dimmed Type to filter, and with no match they show (no matches) and dim the pick button. In Submit review's verdict, Editor settings' line endings and the language server choice, the arrows choose directly, and one Tab leaves.

Closes #572

Worth knowing

  • Filtering is now the library's (ListFilter: CamelHumps, then substring), so a picker matches at least the rows it did before. Matches are now ranked by score rather than kept in list order. Choose grammar still opens on the current grammar.
  • In Definitions of, Esc still clears a non-empty filter before it cancels, and the Cancel button does the same.
  • Go to line's error (Line out of range) is now the library's alert block, under the buttons, where the library puts it.
  • HostedConfirm keeps its own hosting for now, so confirms still have no F1 sheet. Moving it onto HostedDialog would give them one, but that's a new key and out of scope here.

🤖 Generated with Claude Code

a-team try tuicode 596

…Dialog

Open recent folder, Definitions of, Choose grammar, Go to line and the
language server dialog are now MentalDesk.Tui dialogs: their keys are on
buttons, the hint rows are gone, and F1 opens Help with the dialog's keys.
HostedDialog hosts any AppDialog on the scope stack and answers its F1 with
a KeysDialog, putting the caret back where it was when Help closes.

The three OptionSelectors call SelectOnArrows(), so the arrows choose and
one Tab leaves. TuiCode's own filtering, hint text and per-dialog command
ids for these dialogs are deleted.

Closes #572

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@a-team-app
a-team-app Bot marked this pull request as ready for review October 23, 2026 09:58
@jamescrosswell
jamescrosswell merged commit c1b09f1 into main Oct 23, 2026
30 checks passed
@jamescrosswell
jamescrosswell deleted the milestone-572-picker-keys branch October 23, 2026 10:08
a-team-app Bot added a commit that referenced this pull request Oct 23, 2026
Keep the QuickInfo command ids; main dropped the DefinitionPicker ones (#596).

Closes #591

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant