Repository navigation
Jumping into a file that isn't open yet lands the line two rows below the sticky lines - #589
Merged
Merged
Conversation
A jump into a file that isn't open yet scrolled before the symbol scan had found the file's pins, so it allowed for none, and the pins then covered the two lines of context above the target. EditorTab now remembers a jump made while the pins aren't known and makes it again in the draw where the scan finishes, unless the view, the caret or the text has changed since. A file scanned in one frame lands right on its first draw. Restoring a remembered position (#514) doesn't count as a jump. GoToDefinitionHostTests expected the old landing, with no room for the `class Diff` pin. Closes #588 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jumping into a file that isn't open yet now lands the line two rows below the sticky lines, with the two lines before it in view, the same as Go to line once the file is open. That covers
tuicode file:line, Find in files, Go to definition, Usages, the History panel and Back/Forward into a closed file, with or without word wrap.On a large file the pins can take a moment to appear, and the view then shifts down a row or two once. If you scroll, type, click or move the cursor before that, it stays where you put it. Opening a file without a line, or reopening one at its remembered position, scrolls as before.
Closes #588
Checked in the real app with
tuicode src/TuiCode.Workbench/Workbench.cs:229: once the scan finishes it shows pins 13 and 224, then 227 and 228, then 229.a-team try tuicode 589