Repository navigation
Fix random crashes on macOS when started from lazygit, gh or another Go tool - #584
Open
a-team-app[bot] wants to merge 3 commits into
Open
a-team-app[bot] wants to merge 3 commits into
a-team-app[bot] wants to merge 3 commits into
Conversation
On macOS, Native AOT builds from ILCompiler 10.0.12 crash on a GC when a Go program started them (dotnet/runtime#132581, fixed in 10.0.13). The SDK picks the ILCompiler, so global.json asks for 10.0.402 (rolling forward within 10.0, no previews), and CI and the release workflow install the SDK it names instead of a floating 10.0.x. Closes #563 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
7 tasks
Contributor
Author
|
CI fails here because The SDK pin itself works: setup-dotnet resolved and the build reached compile on both runners. Leaving this a draft. Once a fix for that test lands on |
Open
2 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every build of TuiCode, local, CI and release, now uses SDK 10.0.402 or a newer 10.0 SDK. Its Native AOT compiler is ILCompiler 10.0.13, which fixes the macOS crash when TuiCode is started by a Go program: lazygit or
ghopening it as$EDITOR, or tuirec (dotnet/runtime#132581).Closes #563
What changed
global.jsonasks for SDK 10.0.402, withrollForward: latestFeatureandallowPrerelease: false. A newer 10.0 SDK is accepted. An older one or a .NET 11 preview isn't.buildandaotjobs, andrelease.yml, install the SDK throughglobal-json-file: global.jsoninstead of a floating10.0.x.AGENTS.mdQuick start says which SDK to install.Checked on this Mac
"runtime.osx-arm64.Microsoft.DotNet.ILCompiler/10.0.13"(src/TuiCode/obj/project.assets.json). I'll add the CIaotlog line once it has run.dotnet buildstops withA compatible .NET SDK was not found. Requested SDK version: 10.0.402. So a .NET 11 SDK doesn't satisfy the pin either.global.jsonand launched by tuirec 0.9.1, ran 10 times on each SDK:EXC_BAD_ACCESS (SIGSEGV),pc=0x0,x0=30.200 GCs, no crashall 10 times.AGENTS.mdopen, was sentSIGUSR1five times. It kept running and kept scrolling afterwards. In macOS: TuiCode segfaults when started by a Go program such as tuirec (.NET 10.0.12 NativeAOT signal bug) #509 a 10.0.12 build died on the first one.Worth flagging
dotnet(SDK 10.0.105) is first onPATH. It only sees its own SDKs, so a plaindotnet buildin this repo now fails with "SDK not found" until/usr/local/share/dotnetcomes first onPATHor Homebrew's dotnet reaches 10.0.4xx. That's the pin working as intended, but it will catch anything that runsdotnetfrom Homebrew, includinga-team try.UnsavedEditsHostTestsstill uses theConfirmViewthat Every "are you sure?" confirms with Ctrl+Enter, gives each choice its own key, and ignores Enter #582 removed. This PR moves that test toConfirmDialogsso it can go green. Whichever PR merges first fixes main.a-team try tuicode 584