This repository was archived by the owner on Apr 24, 2023. It is now read-only.
Fixes for Julia0.7 and 1.0 - #1
Open
louisponet wants to merge 2 commits into
Open
Conversation
Please review the convert thing in copy, it was the only way to get the permutedims! to work and give the correct InexactError. Should ReinterpretedArray be allowed as DenseArray??
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tests run on julia 0.7.0, There was one docstring bug uncovered in
Traits.jlwhich has a PR in Base julia, it's marked by the#TODO.reinterpretreturnsReinterpretedArrayinstead ofDenseArray, maybe this should be allowed? To fix I addedcollecteverywhere.Lastly, I had to add a
convert.(...)in acopy!method forAxisArraysto getpermutedims!to work and give the correctInexactError. Please check if this is the correct fix, marked by#REVIEW