build(fix): harden shell and installer reruns - #44
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd05c6a030
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83fb855b3a
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if grep -Fqx "$marker_line" "$file"; then | ||
| continue |
There was a problem hiding this comment.
When a managed block already exists, this helper now skips the entire write based only on the static marker, so reruns cannot update dynamic content passed by callers. For example, rerunning the Git section after choosing a different SSH key name builds a new IdentityFile $KEY_PATH, but the existing # Git SSH (Added by MacSetup) marker makes this continue, leaving ~/.ssh/config pointing at the old key while the section still reports success; the same stale-block behavior affects generated Postgres paths after version changes.
Useful? React with 馃憤聽/ 馃憥.
1 participant
Summary
.shell_commonso zsh no longer sources the full Bash rc file and trips Bash-only bindings.IFSin logging/PATH helpers, guarding asdf plugin adds, and fixing command-substitution execution bugs.Test plan
./test.sh