feat: declare the vendored modules in a manifest - #60
Merged
Conversation
mcanouil
marked this pull request as ready for review
September 6, 2026 12:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The seven Lua modules taken from
quarto-lua-modulesnow live in_extensions/gitlink/_vendor/quarto-lua-modules/, and_extensions/gitlink/_dependencies.ymlrecords the release and the SHA-256 of each one at version 2.0.0.Every vendored file can now be checked against the release it came from.
Six modules matched the published 1.0.0 files and were replaced by their 2.0.0 counterparts.
The seventh,
string.lua, carried a local@version 1.1.0that no release published, so it was adopted as declared and then brought to 2.0.0.Two first-party modules needed hand editing, which is the part of this diff a reader will not expect.
_modules/bitbucket.luaand_modules/widget.luastay first party, but each reached its dependencies through aload_siblinghelper that built a path at run time fromdebug.getinfoand pointed into_modules/, which no longer holds those files.Both now use the same
quarto.utils.resolve_path('_vendor/quarto-lua-modules/...')call the entry point already used, and the helper, left without callers, is gone from both files.This also names the licence and the author in
docs/_scripts/sync-extension.sh, which still carried the scaffolder placeholders.The manifest report flagged eleven further references to the moved modules, all from files that Git either does not track or ignores.
Seven come from the working copy of this extension under
docs/_extensions/local/, whichsync-extension.shregenerates, and the rest from local notes and local settings that sit outside the extension.None form part of this change, and none were edited.
Rendering
docs/after syncing the extension gives the five pages with no Lua error, the widget configuration on every page, and in-text rewriting unchanged.A Bitbucket document turns
issue #123andpull request #456into links, which exercises thestringmodule through the repointed path inbitbucket.lua.