feat: declare the vendored modules and check the document schema - #40
Merged
Conversation
mcanouil
marked this pull request as ready for review
September 6, 2026 21:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared Lua modules move from
_extensions/elevator/_modules/to_extensions/elevator/_vendor/, declared in a new_extensions/elevator/_dependencies.ymlmanifest.Each file now names the release it came from and carries a digest that can be checked against the published copy.
The manifest declares
html.lua,logging.lua,schema-check.luaandstring.luafromquarto-lua-modulesat 2.1.0, andschema.luafromquarto-wizardat 3.4.0.The entry point loads the modules from their new location.
The extension now checks the document configuration against
_schema.ymlwhile the document renders.The check runs from the shortcode handler, because the extension contributes a shortcode and no filter.
It reports what the schema does not accept and never stops a render, and a schema that cannot be read is reported while the document still builds.
The extension reads its configuration from
extensions.elevator, which is the place the validator reads and the form the documentation uses, so the check covers the documented configuration.The documentation site renders clean.
A probe document set
enabled: "maybe"and an unrecognisedvolumekey underextensions.elevator, and gave the shortcode call an out-of-rangevolumeand an unknown attribute.The check named all four faults and the render still completed.
Removing the vendored
schema-check.luafails the render, which confirms the module is genuinely loaded.Two markdownlint findings in
CHANGELOG.mdare older than this branch and stay untouched, and the historical 1.5.0 entries still name_modules/because they record what shipped at the time.