Skip to content

feat: declare vendored modules and check the document schema - #45

Merged
mcanouil merged 3 commits into
mainfrom
feat/declare-vendored-dependencies
Sep 6, 2026
Merged

feat: declare vendored modules and check the document schema#45
mcanouil merged 3 commits into
mainfrom
feat/declare-vendored-dependencies

Conversation

@mcanouil

@mcanouil mcanouil commented Sep 6, 2026

Copy link
Copy Markdown
Owner

The five shared Lua modules move from _modules/ to _vendor/quarto-lua-modules/, and _dependencies.yml now names the release each one came from, so every file can be checked against its source.
The entry point is repointed accordingly and nothing is left under _modules/.
The extension also checks the document configuration against _schema.yml and reports what the schema does not accept.
The check runs from the shortcode handler, because the extension contributes a shortcode and no filter.
It only reports: it never alters the document and never stops a render.

The documentation render is clean and exits 0, with no missing module and no error.

One thing is worth a look before this is released.
The validation reports six warnings per page on this site, of the form 1: is not a recognised key and was ignored., one per entry of the badge array.
The cause is a mismatch between where _schema.yml says the options live and where the extension reads them.
The schema declares badge and badge-overrides as options of the extension, which places them at extensions.badge.badge and extensions.badge.badge-overrides.
The extension instead reads extensions.badge as the badge array itself, and badge-overrides from the top level or from extensions.badge-overrides.
The validator therefore walks the array and treats each numeric index as an unknown option key.
The warnings are accurate about the schema as it stands, so they are left in place rather than silenced.
Correcting the schema is separate work and is not part of this branch.

@mcanouil mcanouil added the Type: Enhancement 💡 Issues related to enhancements, improvements, new features, or new analyses label Sep 6, 2026
@mcanouil mcanouil self-assigned this Sep 6, 2026
@mcanouil mcanouil changed the title feat: declare the vendored modules and check the document against the schema feat: declare vendored modules and check the document schema Sep 6, 2026
@mcanouil
mcanouil marked this pull request as ready for review September 6, 2026 21:36
@mcanouil
mcanouil merged commit be89e1b into main Sep 6, 2026
4 checks passed
@mcanouil
mcanouil deleted the feat/declare-vendored-dependencies branch September 6, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Enhancement 💡 Issues related to enhancements, improvements, new features, or new analyses

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant