Skip to content

fix: tabs: skip privileged about: pages when reopening in a container #2475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erics118 wants to merge 2 commits into
base: v5
Choose a base branch
from
Open

fix: tabs: skip privileged about: pages when reopening in a container #2475

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ecc4a0
fix: tabs: skip privileged about: pages when reopening in a container
erics118 Aug 6, 2026
11a488f
fix: tabs: still reopen about:blank and about:newtab in a container
erics118 Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/services/tabs.fg.create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,13 +525,27 @@ export async function open(

export async function reopenInContainer(ids: ID[], containerId: string) {
Tabs.sortTabIds(ids)
const firstTab = Tabs.byId[ids[0]]
const items = Tabs.getTabsInfo(ids).filter(item => {
// Extensions cannot open privileged about: pages, so keep them open
// instead of replacing them with Sidebery's URL placeholder
const url = item.url
if (
url?.startsWith('about:') &&
url !== 'about:blank' &&
url !== 'about:newtab' &&
!url.startsWith('about:reader?url=')
) {
Logs.warn('Tabs.reopenInContainer: Cannot reopen a privileged about: page:', item.url)
return false
}
return true
})
const firstTab = Tabs.byId[items[0]?.id]
if (!firstTab) return

const idsMap: Record<ID, ID> = {}
IPC.bg('disableAutoReopening', containerId, 1000)

const items = Tabs.getTabsInfo(ids)
setURLsFromTitles(items)
const rule = Tabs.findMoveRuleBy(containerId, firstTab.lvl)
const panel = Sidebar.panelsById[rule?.panelId ?? D.NOID]
Expand Down