docs(plan): record features 011 and 012 as Phases 10 and 9 - #142
Merged
Conversation
The spec-kit realization table stopped at Phase 8 while both new features had merged (#140, #141), so the ledger and the `specs/` tree were out of sync — the condition that table exists to prevent. The phase numbers run **opposite** to the feature numbers, deliberately. Feature 012 (calibration) is the lower phase because it gates feature 011: no probabilistic pass may ship without a holdout frozen before that pass produced its first score (ADR-0027 §3). Numbering them this way makes the existing rule — implementation of a phase MUST NOT begin until the phase beneath it has landed — enforce that dependency mechanically, instead of leaving it to prose in each spec that a reader may not connect to the rule. A note under the table says so, so the inversion reads as a decision rather than a numbering error. The feature directories are numbered the other way because both were scoped concurrently. Both rows state `scoped` per ADR-0014 and nothing above it. Also removes "LLM rubric passes" from the Phase 7+ deferred list, which the new rows contradicted. Their implementation remains blocked, but on named gates rather than on deferral: feature 012's frozen holdout with its precondition gate observed failing (ADR-0016), and an accepted record ratifying the harness-driven architecture. Neither is satisfiable today, which is the correct state. Every figure in the two rows was counted from the merged specs rather than carried over from a report: 011 — 29 FRs, 17 SCs, 42 tasks, four open `[NEEDS CLARIFICATION]`; 012 — 52 FRs, 53 SCs, 77 tasks, 36 `[OBSERVE-FAIL]`, six distinct `[NEEDS CLARIFICATION]` labels. All four relative links resolve against the tree. `adr lint`: 27 records, 0 errors, 0 warnings. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Mark Beacom <m@beacom.dev>
There was a problem hiding this comment.
Pull request overview
Updates the phase ledger to reflect recently scoped evaluator work.
Changes:
- Adds calibration as Phase 9 and probabilistic passes as Phase 10.
- Documents their inverted feature numbering and dependency.
- Removes LLM rubric passes from deferred work.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+44
to
+45
| §3). Numbering them this way makes the rule below — implementation of a phase | ||
| MUST NOT begin until the phase beneath it has landed — enforce that dependency |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Records the two newly-merged features in
plan.md's spec-kit realization table. The table stopped at Phase 8 while #140 and #141 had already merged, so the ledger and thespecs/tree were out of sync — the exact condition that table exists to prevent.specs/012-evaluator-calibration/scoped(#141)specs/011-probabilistic-evaluator-passes/scoped(#140)The phase numbers are inverted, deliberately
Feature 012 is the lower phase, and its feature directory is numbered higher. That is not a mistake, and a note under the table says so.
012 gates 011: no probabilistic pass may ship without a holdout frozen before that pass produced its first score (ADR-0027 §3).
plan.mdalready carries the rule that implementation of a phase MUST NOT begin until the phase beneath it has landed. Numbering calibration as the lower phase makes that existing rule enforce the dependency mechanically, instead of leaving it to prose inside each spec that a reader may never connect to the rule.The feature directories run the other way because both were scoped concurrently.
Phase 7+ deferral corrected
"LLM rubric passes" was still listed as deferred, which the new rows contradicted. Removed — but their implementation is still blocked, now on named gates rather than on deferral:
Neither is satisfiable today, which is the correct state for a
scopedfeature.Figures were counted, not carried
Every number in the two rows was derived from the merged specs rather than copied from a session report — this PR's predecessor shipped a fabricated duration ("eleven months" for a 25-day span) precisely because a figure was asserted and then repeated:
[NEEDS CLARIFICATION][OBSERVE-FAIL], six distinct[NEEDS CLARIFICATION]labelsCounting distinct labels rather than token occurrences matters here: 012's spec contains more occurrences than questions, and 011's contains a prose sentence naming the token. Both rows state
scopedper ADR-0014 and nothing above it.Verification
adr lint— 27 records, 0 errors, 0 warningsDocumentation only; no code, no corpus changes.