Repository navigation
feat(alert): add themeable subtle variant - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22.
Summary
Alertvariant API:default | subtlecolor-mix()values--bits-alert-surfaceand--bits-alert-borderso themes can supply exact authored colors without private selectorsicon={null}to omit the marker entirelyrole="status"semantics by default while preserving explicit role overridesReview notes
The default variant still uses
--bits-raised, the full alert tone border, the existing 24px glyph marker, androle="alert"for danger. Existing consumers therefore retain their markup, visual weight, and live-region behavior.For
variant="subtle", the default surface is an 8% tone wash over--bits-surface; the border is a 30% tone mix over the same surface. Both declarations first read--bits-alert-surface/--bits-alert-border, so a theme container can replace the derived values without targeting.bits-alert-*internals.Verification
npm run checkunder Node 24.13.1role="alert"role="status"--bits-alert-surface: #170d0bresolved torgb(23, 13, 11)--bits-alert-border: #4a231cresolved torgb(74, 35, 28)Visual evidence
Ember · default versus subtle emphasis
Ocean · default versus subtle emphasis
Ember · authored theme override
Ember · 320px viewport