Repository navigation
feat(dialog): support form workflows - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21.
Summary
childrenbody toDialogwhile keepingdescriptionas prose-only accessible descriptionsm/mddialog sizes and a scroll-contained responsive panelconfirmDisabled,confirmLoading, andconfirmLoadingLabel, passed through to the existingButtonSelectconsume the first Escape before its containing dialog closesReview notes
The change is additive: the default
smwidth remains 372px and existing confirmation-only call sites do not need changes. Form controls render in.bits-dialog__content, outside the description<p>, andaria-describedbycontinues to reference onlydescription.At 480px and below, the panel uses token-based 16px gutters and stacks actions without changing their DOM/keyboard order. The body scrolls independently when content exceeds the viewport, while the action footer remains available.
Verification
npm run checkunder Node 24.13.1aria-busy="true"Visual evidence
Ember · initial invalid form
Ember · completed form
Ocean · loading confirmation
Ember · 320px viewport