zabbix 5 new tables

[ironbishop]

Version 0.9.3 doesn't list zabbix 5 new tables, and (on psql/timescaledb) outputs:

Reading database options from /etc/zabbix/zabbix_server.conf...
 Configuration:
  - type:     psql
  - host:     ...
  - port:     5432
  - schema:   public
  - database: zabbix
  - user:     zabbix
  - output:   /root
 Fetching list of existing tables...
 ERROR
 Unknown tables found in database:
  - interface_snmp
  - lld_override
  - lld_override_condition
  - lld_override_opdiscover
  - lld_override_operation
  - lld_override_ophistory
  - lld_override_opinventory
  - lld_override_opperiod
  - lld_override_opseverity
  - lld_override_opstatus
  - lld_override_optag
  - lld_override_optemplate
  - lld_override_optrends
  - media_type_message
  - module
  - task_data
  - task_result
 To include them (full data backup) specify -f, to ignore them use -i

Note: this PR contains a version bump.

[ironbishop]

Checked that it's the same column set on MySQL too.

[rufik]

Output for Zabbix 5.0.1 on MySQL 8.0:

Configuration:
 - type:     mysql
 - host:     xxxxxx
 - port:     3306
 - database: xxxxxx
 - user:     xxxxxx
 - output:   /root/zbx_backup
Fetching list of existing tables...

ERROR
Unknown tables found in database:
 - interface_snmp
 - lld_override
 - lld_override_condition
 - lld_override_opdiscover
 - lld_override_operation
 - lld_override_ophistory
 - lld_override_opinventory
 - lld_override_opperiod
 - lld_override_opseverity
 - lld_override_opstatus
 - lld_override_optag
 - lld_override_optemplate
 - lld_override_optrends
 - media_type_message
 - module
 - task_data
 - task_result
To include them (full data backup) specify -f, to ignore them use -i

[tanertas]

Is this patch tested for dump and restore?

[ironbishop]

Backup is working for me. Restore not tested.

Dishonor on me, dishonor on my cow.

[hermanekt]

Backup and restore working fine.

[hermanekt]

BACKUP
git clone https://github.com/hermanekt/zabbix-backup/blob/master/zabbix-dump
./zabbix-dump -t psql -H localhost -P 5432 -o /var/backup

RESTORE
systemctl stop zabbix-server.service
sudo -u postgres dropdb zabbix
sudo -u postgres createdb -O zabbix zabbix

echo "CREATE EXTENSION IF NOT EXISTS timescaledb CASCADE;" | sudo -u postgres psql zabbix
echo "SELECT timescaledb_pre_restore();" | sudo -u postgres psql zabbix

gunzip /var/backup/zabbix_cfg_localhost_20200730-1810_db-psql-5.0.1.sql.gz
sudo -u postgres psql zabbix < /var/backup/zabbix_cfg_localhost_20200730-1810_db-psql-5.0.1.sql

echo "SELECT timescaledb_post_restore();" | sudo -u postgres psql zabbix
systemctl restart postgresql-12.service
systemctl start zabbix-server.service

[maxhq]

Hey all! Thanks a lot for testing and reporting. As soon as I am working with Zabbix again I will merge this. But it will take some more days.
Sorry for the delay ... as usual ;-)

[jokay]

What about replacing all existing (and still existing 😉) from x.x.x - 4.4.4 to x.x.x - 5.0.0 as well?

[ironbishop]

ok but, i tought that was only a comment, isn't it? it is not used in the code. what is those columns purpose?

zabbix-backup/zabbix-dump

Lines 418 to 423 in 811d064

	while read -r line; do
	table=$(echo "$line" | cut -d" " -f1)
	echo "$line" | cut -d" " -f5 | grep -qi "SCHEMAONLY"
	test $? -eq 0 && SCHEMAONLY_TABLES+=($table)
	KNOWN_TABLES+=($table)
	done < <(sed '0,/^__DATA__$/d' "${BASH_SOURCE[*]}" | tr -s " ")

[maxhq]

@ironbishop You are right, it is not currently used.
I might use it in a future version to warn if old tables still exist in the database...

[jokay]

ok but, i tought that was only a comment, isn't it? it is not used in the code.

Yes, but the fact it's only a comment doesn't mean it shouldn't be maintained.

[ironbishop]

i bumped all tables present in my environment. im currently using 5.0.2

[jurim76]

zabbix 5.2. has a new tables

• item_parameter
• role
• role_rule
• trigger_queue

[xray-sky]

We really need support for 5.0. Any estimate when this might be merged? If there are outstanding tasks needing done, e.g. around testing, I'm happy to contribute what I can to that.

[jokay]

@maxhq any updates on this?

[maxhq]

@jokay @xray-sky my problem is that I rarely interact with Zabbix these days, do not have a recent version installed and currently have no spare time.
As @hermanekt wrote above the patch is working for him, so please use his version (https://raw.githubusercontent.com/hermanekt/zabbix-backup/master/zabbix-dump) until I find time for releasing a new version with the recent PRs.
If anyone is willing to take over the maintenance of this script, just tell me, fork this repo and I‘ll mention it in my README.
Sorry for the inconvenience!

[jokay]

@maxhq thx for the feedback 👍

[ironbishop]

I am already maintaining the script for my needs, the fork is npotorino/zabbix-backup ...

I do not plan to have a lab with every version installed, so I do not plan to support intermediate versions (x.2 and x.4, for x >=5) unless I'm actively using it in my environment.

edit:
using Github actions, it might be possible to automate all versions check .. and that could solve the tests issue, at least partially.

[jokay]

I think supporting active LTS version(s) may already work for the most people?

[colttt]

with Zabbix 5.4 I got an error:

ERROR
Unknown tables found in database:
 - dashboard_page
 - httptest_tag
 - item_parameter
 - item_tag
 - report
 - report_param
 - report_user
 - report_usrgrp
 - role
 - role_rule
 - script_param
 - sysmaps_element_tag
 - token
 - trigger_queue
 - valuemap
 - valuemap_mapping
To include them (full data backup) specify -f, to ignore them use -i

[ironbishop]

@colttt can you please test branch https://github.com/npotorino/zabbix-backup/tree/zabbix-5-4-tables and confirm it's working fine without the "unknown tables" message?

[ironbishop]

tested on 5.2 and 5.4, good for me 👍

[accessone67]

@ironbishop - new version works zabbix v5.4.6. Thank you,

[hermanekt]

Hi i created updated version for 6.0 ready, i also fix some issues. https://github.com/hermanekt/zabbix-backup

[ironbishop]

@hermanekt would you like to add your tables as a PR to https://github.com/npotorino/zabbix-backup
also which issues did you fix
also please make edits on a branch instead of directly commit to master/main branch
also i dont fully understand why you need the custom format dump

[maxhq]

Everybody following here might want to read my comment about the future development.