Skip to content

Escape parentheses in URLs #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oxygen-dioxide wants to merge 1 commit into from
Closed

Escape parentheses in URLs #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions markdownify/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,9 @@ def convert_a(self, el, text, parent_tags):
if not text:
return ''
href = el.get('href')
# Escape parentheses in URLs to prevent breaking markdown link syntax
if href:
href = href.replace('(', '%28').replace(')', '%29')
title = el.get('title')
# For the replacement see #29: text nodes underscores are escaped
if (self.options['autolinks']
Expand Down
8 changes: 8 additions & 0 deletions tests/test_conversions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,14 @@ def test_a_in_code():
assert md('<pre><a href="https://google.com">Google</a></pre>') == '\n\n```\nGoogle\n```\n\n'


def test_a_parentheses_in_url():
html = ('<a href="http://en.wiktionary.org/wiki/)">close-paren on wiktionary</a>'
'<br/><a href="http://en.wiktionary.org/wiki/(">open-paren on wiktionary</a>')
expected = ('[close-paren on wiktionary](http://en.wiktionary.org/wiki/%29) \n'
'[open-paren on wiktionary](http://en.wiktionary.org/wiki/%28)')
assert md(html) == expected


def test_b():
assert md('<b>Hello</b>') == '**Hello**'

Expand Down