Skip to content

Remove nightly schedule trigger and run CI on main - #248

Merged
davidkrauser merged 1 commit into
masterfrom
dk-drop-schedule-trigger
Aug 13, 2026
Merged

davidkrauser merged 1 commit into
masterfrom
dk-drop-schedule-trigger

Conversation

@davidkrauser

Copy link
Copy Markdown
Contributor

Implements @hanzei's suggestion in #247.

  • Remove the daily schedule trigger, which causes GitHub to disable the entire workflow (including pull_request checks) after 60 days of inactivity in derived repos.
  • Extend the push branch list to master, main, so repos created from this template with a main default branch get post-merge CI.

🤖 Generated with Claude Code

The schedule trigger causes GitHub to disable the entire workflow after 60
days of inactivity in derived repos, silently taking pull_request checks
with it. The push trigger only matched master, so repos created from this
template with a main default branch never ran post-merge CI.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@davidkrauser
davidkrauser requested a review from hanzei August 12, 2026 15:50
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 97fb3ce6-9cba-4de7-91d6-ab8c776bd405

📥 Commits

Reviewing files that changed from the base of the PR and between e1f9f88 and 1b44058.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

The CI workflow no longer runs on a daily schedule. Pushes to both master and main now trigger CI.

Changes

CI trigger updates

Layer / File(s) Summary
Workflow trigger configuration
.github/workflows/ci.yml
The workflow removes the scheduled cron trigger and adds main to the push branch filters while retaining master.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

  • Issue #247: The workflow changes remove the daily schedule trigger and add main alongside master, matching the issue objectives.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the removal of the nightly schedule and the addition of CI for the main branch.
Description check ✅ Passed The description accurately explains the workflow changes and their purpose for derived repositories.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dk-drop-schedule-trigger

Comment @coderabbitai help to get the list of available commands.

@hanzei hanzei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👍

@davidkrauser
davidkrauser merged commit 3296cf6 into master Aug 13, 2026
7 checks passed
@davidkrauser
davidkrauser deleted the dk-drop-schedule-trigger branch August 13, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants