fix(frontend): reuse prepared specialization metadata - #27816
Closed
ck89119 wants to merge 6 commits into
Closed
Conversation
# Conflicts: # pkg/frontend/computation_wrapper.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
Related to #27807
What this PR does / why we need it:
Withdrawn: the performance baseline originally reported here predated #27556 (
8b6a44e83ca), while this PR's actual base already contained that change.On the actual base (
52336df805), the production path passes the cachedneedsRuntimeSpecialization=truevalue. The base helper therefore short-circuits beforePreparedPlanNeedsRuntimeSpecialization, so the control added by this PR with a forcedfalsevalue was not reachable for the TPCC arithmetic DML path.An exact-base/head rerun of the same reachable benchmark produced identical allocation results:
52336df805dab9d1a1ebThe timing difference is noise-level and allocations are identical. Consequently, this PR does not provide evidence of an improvement over its current base and should not be merged.
#27556 already restored the cached-specialization production path implicated by #27807. The issue's TPCC 100/100/5-minute acceptance threshold still needs to be validated separately against that merged revision.