fix: preserve prepared arithmetic and exact integer semantics - #27795
Draft
ck89119 wants to merge 6 commits into
Draft
fix: preserve prepared arithmetic and exact integer semantics#27795ck89119 wants to merge 6 commits into
ck89119 wants to merge 6 commits into
Conversation
# Conflicts: # pkg/frontend/computation_wrapper.go # pkg/sql/plan/utils.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #25408
issue #27492
What this PR does / why we need it:
Prepared executions transport SQL user-variable values and binary-protocol string values through text-backed parameter vectors. Two related runtime-specialization gaps could therefore reuse or select an approximate domain that did not match the current execution:
EXECUTE ... USINGarithmetic could retain an earlier integer cast when a later execution supplied DECIMAL;2^53+1through DOUBLE, merging adjacent BIGINT values or raising a BIT range error.This PR keeps the two ownership rules separate while validating them together:
The implementation is based on current
mainafter #27483. No code was cherry-picked from the older broad implementation in #27466.Testing
pkg/sql/planandpkg/frontendtest packagesTestIssue27088PreparedDecimalCommonType, including SQL PREPARE and COM_STMT BIGINT UNSIGNED/BIT(64) string, integer, NULL, and reuse transitionsvet=allforpkg/sql/plan,pkg/frontend, andpkg/tests/issuesmake buildprepare_all.sqlin normal mo-tester comparison mode twice on the same final binary:438 total / 437 success / 0 failed / 1 ignored / 0 abnormalin both runs