Skip to content

Fix sg - #1501

Open
minhsueh wants to merge 2 commits into
mainfrom
fix-sg
Open

Fix sg#1501
minhsueh wants to merge 2 commits into
mainfrom
fix-sg

Conversation

@minhsueh

Copy link
Copy Markdown
Collaborator

Fix space group parsing:

  1. Centralize the use of unicodeify_spacegroup from Pymatgen.
  2. Fix htmlify_spacegroup.

Note: Testing is blocked until the corresponding Pymatgen PR is merged.

@codecov-commenter

codecov-commenter commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.11%. Comparing base (3f2daf4) to head (107cca6).

Files with missing lines Patch % Lines
...met-core/emmet/core/featurization/robocrys/util.py 50.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3f2daf4) and HEAD (107cca6). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (3f2daf4) HEAD (107cca6)
15 12
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1501       +/-   ##
===========================================
- Coverage   85.14%   73.11%   -12.03%     
===========================================
  Files         230      152       -78     
  Lines       18900    13120     -5780     
===========================================
- Hits        16092     9593     -6499     
- Misses       2808     3527      +719     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants