fix(core): reject unsupported TaskProtocol retry settings - #66
Open
kingpy-bot wants to merge 3 commits into
Open
fix(core): reject unsupported TaskProtocol retry settings#66kingpy-bot wants to merge 3 commits into
kingpy-bot wants to merge 3 commits into
Conversation
Widen test_max_retries_is_rejected to a parametrized test that covers negative, small, and large non-zero max_retries values, not just max_retries=1. The docstring contract is 'max_retries must currently be 0', and the validation should reject every non-zero int, not just the smallest one. Refs: maseval#66
|
Thanks for taking the fail-loud route here. I reproduced the original silent no-op and reviewed this branch locally. The core suite passes, but I found two gaps that appear blocking before merge:
A minimal completion could keep the current constructor validation, add execution-boundary validation before callbacks/workers are started, change the two built-in benchmark defaults and docs to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #62.
Summary
TimeoutAction.RETRY/EXTENDandTaskProtocol.max_retriesas reserved until execution-loop retry handling existsTaskProtocol.__post_init__validation so unsupported retry settings fail loudly instead of being silently ignoredTests
.venv/bin/python -m pytest tests/test_core/test_task_protocol.py tests/test_core/test_benchmark/test_report_schema.py -q.venv/bin/python -m pytest tests/test_core -q.venv/bin/ruff check maseval/core/task.py tests/test_core/test_task_protocol.py.venv/bin/ruff format --check maseval/core/task.py tests/test_core/test_task_protocol.py.venv/bin/ty check maseval/core/task.py tests/test_core/test_task_protocol.pygit diff --checkAI-assisted contribution: prepared with an AI coding assistant and manually verified with the commands above.