Repository navigation
Add Contao 6 support - #35
Merged
Merged
Conversation
- Require contao/core-bundle ^5.7 || ^6.0 and Symfony ^6.4 || ^7.0 || ^8.0 - Declare the directly used Symfony components, Doctrine DBAL and Twig - Run PHPUnit from the root and remove tools/phpunit - Use stubs instead of mocks without expectations (PHPUnit 12 notices) - Modernize the CI workflow and fix the ECS config header Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jb7ViNYJwLjr2Y34g8aAoK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Contao 6 support. The bundle already required Contao 5.7, so there was no Contao 4 code to remove; it now requires
^5.7 || ^6.0.Tested in CI against Contao 5.7.14 (lowest), 5.7.15 and 6.0.4 (Symfony 7.4 / 8.1) on PHP 8.3–8.5. All bundle classes also load without errors under Contao 6 and Symfony 8. I checked this with a temporary CI step that has since been removed.
The code itself needed no changes for Contao 6:
BE_MODkey callbacks (renderAppAction,appMountAction,importAction) and thejavascript/stylesheetmodule assets are still supported by the Contao 6 back end.Changes
contao/core-bundle^5.7 || ^6.0.^6.4 || ^7.0 || ^8.0), as aredoctrine/dbalandtwig/twig.phpunit/phpunitandsymfony/phpunit-bridgefrom require-dev. PHPUnit comes withcontao/test-case.typeis nowcontao-bundle.phpunit.xml.dist.tools/phpunitis removed.WidgetFactoryTestuses stubs instead of mocks without expectations. This removes the 3 PHPUnit 12 notices.--prefer-lowest.Note
PR #34 (Sioweb, "Add delimitter and enclosure") also targets
5.4.x. It touches only one file, so it should not conflict with this PR.Suggested release: 5.5.0.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Jb7ViNYJwLjr2Y34g8aAoK
Generated by Claude Code