Fix empty reducer shard shuffle reads - #8772
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8cf52ec51
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8af75c02c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| captured_fan_in.append(kwargs["fan_in"]) | ||
| return real_merge(*args, **kwargs) | ||
|
|
||
| monkeypatch.setattr("zephyr.shuffle._merge_sorted_frames", merge_and_record) |
There was a problem hiding this comment.
This test patches two functions inside the system under test and then asserts the argument passed to _merge_sorted_frames, so it fails on harmless helper refactors and would still pass if that helper accepted fan_in=2 but ignored it. Remove these internal patches and verify the actual spill behavior through the existing scan/filesystem recorder—for example, require .spill paths to be observed—while retaining the merged-output assertion. The repository's required testing policy specifically calls for rejecting tests based on internal dispatch rather than observable behavior.
AGENTS.md reference: AGENTS.md:L239-L245
Useful? React with 👍 / 👎.
|
Hi, could you please approve/run the pending workflows for PR #8772? |
1 participant
No description provided.